Issue 20973: Cartan type Aoo

archive/issues_020736.json:

{
    "assignees": [],
    "body": "<div id=\"comment:0\"></div>\n\nGives a *minimal* implementation of the `A_oo` Cartan type:\n\n```sage\nsage: CartanType(['A',oo])\n['A', oo]\nsage: CartanType(['A',oo]).is_irreducible()\nTrue\nsage: CartanType(['A',oo]).is_simply_laced()\nTrue\nsage: print(CartanType(['A', oo]).ascii_art())\n...---O---O---O---O---O---O---O---...\n     -3  -2  -1   0   1   2   3\n```\n\nIn addition, the ticket fixes the following error in `CartanType`:\n\n```sage\nsage: CartanType(['A',-1])\n  File \"<string>\", line unknown\n\n    ^\nSyntaxError: unexpected EOF while parsing\n```\nThis, and other nonsensical input, now raises a `ValueError`.\n\nSee related discussion on [sage-combinat](https://groups.google.com/forum/#!topic/sage-combinat-devel/tnQngybmlI4).\n\nCC:  @sagetrac-sage-combinat @nthiery @tscrim\n\nComponent: **combinatorics**\n\nKeywords: **Cartan type, A infinity**\n\nAuthor: **Andrew Mathas**\n\nBranch: **[`c1b57e6`](https://github.com/sagemath/sagetrac-mirror/commit/c1b57e673a66cb92d92acefa2cd6f86b236ca7f9)**\n\nReviewer: **Nicolas M. Thi\u00e9ry, Travis Scrimshaw**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20973_\n\n",
    "closed_at": "2016-07-22T06:50:49Z",
    "created_at": "2016-07-07T10:34:36Z",
    "labels": [
        "https://github.com/sagemath/sage/labels/c%3A%20combinatorics",
        "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
        "https://github.com/sagemath/sage/labels/enhancement"
    ],
    "milestone": "https://github.com/sagemath/sage/milestones/sage-7.3",
    "reactions": [],
    "repository": "https://github.com/sagemath/sage",
    "title": "Cartan type Aoo",
    "type": "issue",
    "updated_at": "2016-08-16T11:33:45Z",
    "url": "https://github.com/sagemath/sage/issues/20973",
    "user": "https://github.com/AndrewAtLarge"
}

Gives a minimal implementation of the A_oo Cartan type:

sage: CartanType(['A',oo])
['A', oo]
sage: CartanType(['A',oo]).is_irreducible()
True
sage: CartanType(['A',oo]).is_simply_laced()
True
sage: print(CartanType(['A', oo]).ascii_art())
...---O---O---O---O---O---O---O---...
     -3  -2  -1   0   1   2   3

In addition, the ticket fixes the following error in CartanType:

sage: CartanType(['A',-1])
  File "<string>", line unknown

    ^
SyntaxError: unexpected EOF while parsing

This, and other nonsensical input, now raises a ValueError.

See related discussion on sage-combinat.

CC: @sagetrac-sage-combinat @nthiery @tscrim

Component: combinatorics

Keywords: Cartan type, A infinity

Author: Andrew Mathas

Branch: c1b57e6

Reviewer: Nicolas M. Thiéry, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20973

archive/issue_events_292434.json:

{
    "actor": "https://github.com/AndrewAtLarge",
    "created_at": "2016-07-07T10:34:36Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "milestone_number": null,
    "milestone_title": "sage-7.3",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20973#event-292434"
}

archive/issue_events_292435.json:

{
    "actor": "https://github.com/AndrewAtLarge",
    "created_at": "2016-07-07T10:34:36Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
    "label_color": "ffbb00",
    "label_name": "p: major / 3",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20973#event-292435"
}

archive/issue_comments_304687.json:

{
    "body": "Branch: **[u/andrew.mathas/cartan_type_aoo](https://github.com/sagemath/sagetrac-mirror/tree/u/andrew.mathas/cartan_type_aoo)**",
    "created_at": "2016-07-07T10:37:16Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304687",
    "user": "https://github.com/AndrewAtLarge"
}

Branch: u/andrew.mathas/cartan_type_aoo

archive/issue_comments_304688.json:

{
    "body": "Description changed:\n``````diff\n--- \n+++ \n@@ -1 +1,25 @@\n+Gives a minimal implementation of the `A_oo` Cartan type:\n \n+```sage\n+sage: CartanType(['A',oo])\n+['A', oo]\n+sage: CartanType(['A',oo]).is_irreducible()\n+True\n+sage: CartanType(['A',oo]).is_simply_laced()\n+True\n+sage: print(CartanType(['A', oo]).ascii_art())\n+...---O---O---O---O---O---O---O---...\n+     -3  -2  -1   0   1   2   3\n+```\n+\n+In addition, the ficket fixes the following error:\n+\n+```sage\n+sage: CartanType(['A',-1])\n+  File \"<string>\", line unknown\n+\n+    ^\n+SyntaxError: unexpected EOF while parsing\n+```\n+\n+See related discussion on [sage-combinat](https://groups.google.com/forum/#!topic/sage-combinat-devel/tnQngybmlI4).\n``````\n",
    "created_at": "2016-07-07T10:43:53Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304688",
    "user": "https://github.com/AndrewAtLarge"
}

Description changed:

--- 
+++ 
@@ -1 +1,25 @@
+Gives a minimal implementation of the `A_oo` Cartan type:
 
+```sage
+sage: CartanType(['A',oo])
+['A', oo]
+sage: CartanType(['A',oo]).is_irreducible()
+True
+sage: CartanType(['A',oo]).is_simply_laced()
+True
+sage: print(CartanType(['A', oo]).ascii_art())
+...---O---O---O---O---O---O---O---...
+     -3  -2  -1   0   1   2   3
+```
+
+In addition, the ficket fixes the following error:
+
+```sage
+sage: CartanType(['A',-1])
+  File "<string>", line unknown
+
+    ^
+SyntaxError: unexpected EOF while parsing
+```
+
+See related discussion on [sage-combinat](https://groups.google.com/forum/#!topic/sage-combinat-devel/tnQngybmlI4).

archive/issue_comments_304689.json:

{
    "body": "Commit: **[`257b283`](https://github.com/sagemath/sagetrac-mirror/commit/257b283a7b30fc46cc5bae0bbfcd12037e56eb62)**",
    "created_at": "2016-07-07T10:43:53Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304689",
    "user": "https://github.com/AndrewAtLarge"
}

Commit: 257b283

archive/issue_events_292436.json:

{
    "actor": "https://github.com/AndrewAtLarge",
    "created_at": "2016-07-07T10:43:53Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "label": "https://github.com/sagemath/sage/labels/c%3A%20combinatorics",
    "label_color": "0000ff",
    "label_name": "c: combinatorics",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20973#event-292436"
}

archive/issue_comments_304690.json:

{
    "body": "Author: **Andrew Mathas**",
    "created_at": "2016-07-07T10:43:53Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304690",
    "user": "https://github.com/AndrewAtLarge"
}

Author: Andrew Mathas

archive/issue_comments_304691.json:

{
    "body": "<div id=\"comment:2\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/c52edd107bba7db8ee701890cf68c8593b6de22f\"><code>c52edd1</code></a></td><td><code>Basic functionality for Aoo</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/257b283a7b30fc46cc5bae0bbfcd12037e56eb62\"><code>257b283</code></a></td><td><code>Minimal implementation of Cartan type Aoo</code></td></tr></table>\n",
    "created_at": "2016-07-07T10:43:53Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304691",
    "user": "https://github.com/AndrewAtLarge"
}

New commits:

`c52edd1`	`Basic functionality for Aoo`
`257b283`	`Minimal implementation of Cartan type Aoo`

archive/issue_comments_304692.json:

{
    "body": "Changed keywords from none to **Cartan type, A infinity**",
    "created_at": "2016-07-07T10:43:53Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304692",
    "user": "https://github.com/AndrewAtLarge"
}

Changed keywords from none to Cartan type, A infinity

archive/issue_events_292437.json:

{
    "actor": "https://github.com/AndrewAtLarge",
    "created_at": "2016-07-07T10:43:53Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "label": "https://github.com/sagemath/sage/labels/enhancement",
    "label_color": "696969",
    "label_name": "enhancement",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20973#event-292437"
}

archive/issue_comments_304693.json:

{
    "body": "Description changed:\n``````diff\n--- \n+++ \n@@ -1,4 +1,4 @@\n-Gives a minimal implementation of the `A_oo` Cartan type:\n+Gives a *minimal* implementation of the `A_oo` Cartan type:\n \n ```sage\n sage: CartanType(['A',oo])\n@@ -12,7 +12,7 @@\n      -3  -2  -1   0   1   2   3\n ```\n \n-In addition, the ficket fixes the following error:\n+In addition, the ticket fixes the following error an `CartanType`:\n \n ```sage\n sage: CartanType(['A',-1])\n``````\n",
    "created_at": "2016-07-07T10:46:02Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304693",
    "user": "https://github.com/AndrewAtLarge"
}

Description changed:

--- 
+++ 
@@ -1,4 +1,4 @@
-Gives a minimal implementation of the `A_oo` Cartan type:
+Gives a *minimal* implementation of the `A_oo` Cartan type:
 
 ```sage
 sage: CartanType(['A',oo])
@@ -12,7 +12,7 @@
      -3  -2  -1   0   1   2   3
 ```
 
-In addition, the ficket fixes the following error:
+In addition, the ticket fixes the following error an `CartanType`:
 
 ```sage
 sage: CartanType(['A',-1])

archive/issue_comments_304694.json:

{
    "body": "Description changed:\n``````diff\n\n``````\n",
    "created_at": "2016-07-07T10:46:57Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304694",
    "user": "https://github.com/AndrewAtLarge"
}

Description changed:

archive/issue_comments_304695.json:

{
    "body": "Description changed:\n``````diff\n--- \n+++ \n@@ -12,7 +12,7 @@\n      -3  -2  -1   0   1   2   3\n ```\n \n-In addition, the ticket fixes the following error an `CartanType`:\n+In addition, the ticket fixes the following error in `CartanType`:\n \n ```sage\n sage: CartanType(['A',-1])\n``````\n",
    "created_at": "2016-07-07T11:06:16Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304695",
    "user": "https://github.com/AndrewAtLarge"
}

Description changed:

--- 
+++ 
@@ -12,7 +12,7 @@
      -3  -2  -1   0   1   2   3
 ```
 
-In addition, the ticket fixes the following error an `CartanType`:
+In addition, the ticket fixes the following error in `CartanType`:
 
 ```sage
 sage: CartanType(['A',-1])

archive/issue_comments_304696.json:

{
    "body": "Description changed:\n``````diff\n--- \n+++ \n@@ -21,5 +21,6 @@\n     ^\n SyntaxError: unexpected EOF while parsing\n ```\n+This, and other nonsensical input, now raises a `ValueError`.\n \n See related discussion on [sage-combinat](https://groups.google.com/forum/#!topic/sage-combinat-devel/tnQngybmlI4).\n``````\n",
    "created_at": "2016-07-07T11:07:39Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304696",
    "user": "https://github.com/AndrewAtLarge"
}

Description changed:

--- 
+++ 
@@ -21,5 +21,6 @@
     ^
 SyntaxError: unexpected EOF while parsing
 ```
+This, and other nonsensical input, now raises a `ValueError`.
 
 See related discussion on [sage-combinat](https://groups.google.com/forum/#!topic/sage-combinat-devel/tnQngybmlI4).

archive/issue_comments_304697.json:

{
    "body": "Changed commit from **[`257b283`](https://github.com/sagemath/sagetrac-mirror/commit/257b283a7b30fc46cc5bae0bbfcd12037e56eb62)** to **[`9778f97`](https://github.com/sagemath/sagetrac-mirror/commit/9778f9738c6bf83c66f51ff22ba722e75e96d6ba)**",
    "created_at": "2016-07-07T21:39:19Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304697",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 257b283 to 9778f97

archive/issue_comments_304698.json:

{
    "body": "<div id=\"comment:8\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/9778f9738c6bf83c66f51ff22ba722e75e96d6ba\"><code>9778f97</code></a></td><td><code>Fixing doctest</code></td></tr></table>\n",
    "created_at": "2016-07-07T21:39:19Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304698",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

9778f97 Fixing doctest

archive/issue_comments_304699.json:

{
    "body": "<div id=\"comment:9\" align=\"right\">comment:9</div>\n\nIt is very rudimentary, but comments/suggestions/review welcome",
    "created_at": "2016-07-07T23:46:25Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304699",
    "user": "https://github.com/AndrewAtLarge"
}

comment:9

It is very rudimentary, but comments/suggestions/review welcome

archive/issue_events_292438.json:

{
    "actor": "https://github.com/AndrewAtLarge",
    "created_at": "2016-07-07T23:46:25Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20973#event-292438"
}

archive/issue_comments_304700.json:

{
    "body": "<div id=\"comment:10\" align=\"right\">comment:10</div>\n\nHi Andrew,\n\nOverall, this looks good! It's a bit frustrating to have to write so many methods that are very similar to existing ones, but I did not quite see a good way to factor stuff out either.\n\nOne thing that could be done is to add a class `CartanType_standard` in cartan_type.py (and inherit from it in the `CartanType_standard_*` classes. At least, the inheritance from `UniqueRep` and `SageObject` would be written out only once.\n\nPlugin failures:\n- startup: I guess we can ignore that one\n- trac: in cartan_type.py, the second quote in `trac:`20973'` should be a backquote\n\nSome comments and suggestions:\n\nThe method description in the docstrings is not rather inconsistent. I can see the origin: the rest of the root system code that you took inspiration from is not very consistent either (mostly by my fault :-)). Still it would be good to make it more uniform.\n\n```\n    r\"\"\"\n    Return ... .\n\n    This implements :meth:`` by returning True.\n\n    EXAMPLES::\n\n    \"\"\"\n```\n\nI would move most of the doctests from `type_A_infinity.CartanType.__init__` in the class docstring, as this is useful documentation. Maybe with a bit of text interspersed explaining what this type is about (if this feels natural to you).\n\nWhile you are at it, it should be easy to implement the `index_set` method.\n\nCheers,\n                              Nicolas",
    "created_at": "2016-07-10T14:31:06Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304700",
    "user": "https://github.com/nthiery"
}

comment:10

Hi Andrew,

Overall, this looks good! It's a bit frustrating to have to write so many methods that are very similar to existing ones, but I did not quite see a good way to factor stuff out either.

One thing that could be done is to add a class CartanType_standard in cartan_type.py (and inherit from it in the CartanType_standard_* classes. At least, the inheritance from UniqueRep and SageObject would be written out only once.

Plugin failures:

startup: I guess we can ignore that one
trac: in cartan_type.py, the second quote in trac:20973'` should be a backquote

Some comments and suggestions:

The method description in the docstrings is not rather inconsistent. I can see the origin: the rest of the root system code that you took inspiration from is not very consistent either (mostly by my fault :-)). Still it would be good to make it more uniform.

    r"""
    Return ... .

    This implements :meth:`` by returning True.

    EXAMPLES::

    """

I would move most of the doctests from type_A_infinity.CartanType.__init__ in the class docstring, as this is useful documentation. Maybe with a bit of text interspersed explaining what this type is about (if this feels natural to you).

While you are at it, it should be easy to implement the index_set method.

Cheers, Nicolas

archive/issue_comments_304701.json:

{
    "body": "<div id=\"comment:11\" align=\"right\">comment:11</div>\n\nThinking twice about it, Travis is probably right: once `dynkin_diagram` will be implemented (which should boil down to returning some object such that `t[i][j]` returns the right thing), there is a non trivial chance that the rest of the root system code would work with just minor glitches here and there.\n\nBut if you don't need it yourself, that's for a later ticket.",
    "created_at": "2016-07-10T14:33:51Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304701",
    "user": "https://github.com/nthiery"
}

comment:11

Thinking twice about it, Travis is probably right: once dynkin_diagram will be implemented (which should boil down to returning some object such that t[i][j] returns the right thing), there is a non trivial chance that the rest of the root system code would work with just minor glitches here and there.

But if you don't need it yourself, that's for a later ticket.

archive/issue_comments_304702.json:

{
    "body": "<div id=\"comment:12\" align=\"right\">comment:12</div>\n\nAh: you may want to add this new type to `CartanType.sample`.",
    "created_at": "2016-07-10T14:34:16Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304702",
    "user": "https://github.com/nthiery"
}

comment:12

Ah: you may want to add this new type to CartanType.sample.

archive/issue_comments_304703.json:

{
    "body": "<div id=\"comment:13\" align=\"right\">comment:13</div>\n\nI would like to future proof this by deciding how we want to differentiate between A<sub>+oo</sub> and A<sub>oo</sub>. Unfortunately `oo` is `+Infinity`, so something as subtle as the difference between unsigned infinity and plus infinity might not go over so well. I don't want to hold this up (because this is a good improvement and test use-case), but I do think it is something we should discuss for a moment.",
    "created_at": "2016-07-10T16:19:41Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304703",
    "user": "https://github.com/tscrim"
}

comment:13

I would like to future proof this by deciding how we want to differentiate between A_+oo and A_oo. Unfortunately oo is +Infinity, so something as subtle as the difference between unsigned infinity and plus infinity might not go over so well. I don't want to hold this up (because this is a good improvement and test use-case), but I do think it is something we should discuss for a moment.

archive/issue_comments_304704.json:

{
    "body": "<div id=\"comment:14\" align=\"right\">comment:14</div>\n\nReplying to [@nthiery](#comment%3A10):\n \n> One thing that could be done is to add a class `CartanType_standard` in cartan_type.py (and inherit from it in the `CartanType_standard_*` classes. At least, the inheritance from `UniqueRep` and `SageObject` would be written out only once.\n\nThanks. I almost did something like this when I when I was putting this together. I agree it would be better this way, so I'll try and clean this up a little. Along similar lines, there seems to be quite a lot of code duplication between `cartan_matrix`, `cartan_type`, `dynkin_diagram`, ... I not familiar with the nuances, differences and uses of all of this code but it would be good to clean this up down the track.\n\nAndrew",
    "created_at": "2016-07-10T17:13:45Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304704",
    "user": "https://github.com/AndrewAtLarge"
}

comment:14

Replying to @nthiery:

One thing that could be done is to add a class CartanType_standard in cartan_type.py (and inherit from it in the CartanType_standard_* classes. At least, the inheritance from UniqueRep and SageObject would be written out only once.

Thanks. I almost did something like this when I when I was putting this together. I agree it would be better this way, so I'll try and clean this up a little. Along similar lines, there seems to be quite a lot of code duplication between cartan_matrix, cartan_type, dynkin_diagram, ... I not familiar with the nuances, differences and uses of all of this code but it would be good to clean this up down the track.

Andrew

archive/issue_comments_304705.json:

{
    "body": "<div id=\"comment:15\" align=\"right\">comment:15</div>\n\nReplying to [@tscrim](#comment%3A13):\n> I would like to future proof this by deciding how we want to differentiate between A<sub>+oo</sub> and A<sub>oo</sub>. Unfortunately `oo` is `+Infinity`, so something as subtle as the difference between unsigned infinity and plus infinity might not go over so well. I don't want to hold this up (because this is a good improvement and test use-case), but I do think it is something we should discuss for a moment.\n\nAs you suggested implementing both the `oo` and `+oo` cases I thought about this and got stuck on precisely the problem that `oo == +Infinity`. If anyone has a good idea as to how this should work in terms of syntax I am happy to implement it. It is unfortunate that we can't use:\n\n```sage\nsage: CartanType(['A', oo])\nsage: CartanType(['A',+oo])\n```\nbut, as you say, this won't work.\n\nAnother direction for relatively easy generalisation is `B_oo` etc.\n\nI have a related question concerning `cartan_matrix`, and possibly `dynkin_diagram`. I was surprised that matrices indexed by `Z` and `N` are not implemented in sage and, similarly, that graphs with infinite vertex sets are not supported. It would be very easy to implement a fake Cartan matrix, say `C`, that given two integers makes `C[i,j]`, or `C[i][j]`, return the corresponding entry of the Cartan matrix. Is some one able to tell me what functionality such a matrix would need in order to be useful to the root system code? Similarly, implementing a fake Dynkin diagram class would be straightforward as long as I knew what methods I have to implement.",
    "created_at": "2016-07-10T17:25:58Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304705",
    "user": "https://github.com/AndrewAtLarge"
}

comment:15

Replying to @tscrim:

I would like to future proof this by deciding how we want to differentiate between A_+oo and A_oo. Unfortunately oo is +Infinity, so something as subtle as the difference between unsigned infinity and plus infinity might not go over so well. I don't want to hold this up (because this is a good improvement and test use-case), but I do think it is something we should discuss for a moment.

As you suggested implementing both the oo and +oo cases I thought about this and got stuck on precisely the problem that oo == +Infinity. If anyone has a good idea as to how this should work in terms of syntax I am happy to implement it. It is unfortunate that we can't use:

sage: CartanType(['A', oo])
sage: CartanType(['A',+oo])

but, as you say, this won't work.

Another direction for relatively easy generalisation is B_oo etc.

I have a related question concerning cartan_matrix, and possibly dynkin_diagram. I was surprised that matrices indexed by Z and N are not implemented in sage and, similarly, that graphs with infinite vertex sets are not supported. It would be very easy to implement a fake Cartan matrix, say C, that given two integers makes C[i,j], or C[i][j], return the corresponding entry of the Cartan matrix. Is some one able to tell me what functionality such a matrix would need in order to be useful to the root system code? Similarly, implementing a fake Dynkin diagram class would be straightforward as long as I knew what methods I have to implement.

archive/issue_comments_304706.json:

{
    "body": "<div id=\"comment:16\" align=\"right\">comment:16</div>\n\nPerhaps it would be a bit strange to do `['A', oo, 1]` for **Z** as it is more like A<sub>1</sub><sup>(1)</sup> and it differs from the usual limits of the other finite types.\n\nIt's been a while since I looked deeply into the Dynkin diagram, Cartan type/matrix code. They all inherit from `CartanType_abstract`, but they usually need to direct to the correct representative object to work correctly. One of the good things is that we can add in functionality in layers (i.e., we don't need to do things all at once to make improvements). So a simple class with basic functionality can be a good starting point (on another ticket); this is what I did with Coxeter types.",
    "created_at": "2016-07-10T17:54:44Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304706",
    "user": "https://github.com/tscrim"
}

comment:16

Perhaps it would be a bit strange to do ['A', oo, 1] for Z as it is more like A₁⁽¹⁾ and it differs from the usual limits of the other finite types.

It's been a while since I looked deeply into the Dynkin diagram, Cartan type/matrix code. They all inherit from CartanType_abstract, but they usually need to direct to the correct representative object to work correctly. One of the good things is that we can add in functionality in layers (i.e., we don't need to do things all at once to make improvements). So a simple class with basic functionality can be a good starting point (on another ticket); this is what I did with Coxeter types.

archive/issue_comments_304707.json:

{
    "body": "<div id=\"comment:17\" align=\"right\">comment:17</div>\n\nJust a brief note for now: for the syntax for the various types of infinity, what about using\n\n```\n    sage: CartanType(['A',\\NN])\n    sage: CartanType(['A',\\ZZ])\n```\nThe implementation could be generic and handle both, and even more (e.g. if someone would want to use positive integers as index set, or some parabolic subtype). We could even imagine sharing some stuff with the finite case, but that's probably overdesign.\n\n\n`CartanType(['A',oo])` could be set as an alias to either of them. I would tend to use `\\ZZ`, as the other is a parabolic subtype, but I don't know the field enough to know which one would be the natural default for a mathematician there.",
    "created_at": "2016-07-11T07:49:40Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304707",
    "user": "https://github.com/nthiery"
}

comment:17

Just a brief note for now: for the syntax for the various types of infinity, what about using

    sage: CartanType(['A',\NN])
    sage: CartanType(['A',\ZZ])

The implementation could be generic and handle both, and even more (e.g. if someone would want to use positive integers as index set, or some parabolic subtype). We could even imagine sharing some stuff with the finite case, but that's probably overdesign.

CartanType(['A',oo]) could be set as an alias to either of them. I would tend to use \ZZ, as the other is a parabolic subtype, but I don't know the field enough to know which one would be the natural default for a mathematician there.

archive/issue_comments_304708.json:

{
    "body": "<div id=\"comment:18\" align=\"right\">comment:18</div>\n\nbad syntax for trac link, see patchbot report",
    "created_at": "2016-07-11T07:53:58Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304708",
    "user": "https://github.com/fchapoton"
}

comment:18

bad syntax for trac link, see patchbot report

archive/issue_comments_304709.json:

{
    "body": "Changed commit from **[`9778f97`](https://github.com/sagemath/sagetrac-mirror/commit/9778f9738c6bf83c66f51ff22ba722e75e96d6ba)** to **[`3c53706`](https://github.com/sagemath/sagetrac-mirror/commit/3c5370673410e49fc0acbff86d1ba443c72a44a8)**",
    "created_at": "2016-07-12T10:31:39Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304709",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 9778f97 to 3c53706

archive/issue_comments_304710.json:

{
    "body": "<div id=\"comment:19\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/3c5370673410e49fc0acbff86d1ba443c72a44a8\"><code>3c53706</code></a></td><td><code>Fixing trac link</code></td></tr></table>\n",
    "created_at": "2016-07-12T10:31:39Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304710",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

3c53706 Fixing trac link

archive/issue_comments_304711.json:

{
    "body": "<div id=\"comment:20\" align=\"right\">comment:20</div>\n\nI have addressed all of the comments above. Given the ambiguity between `oo` and `+oo` I have used `NN` and `ZZ` throughout, although `oo` is a synonym for `ZZ`:\n\n```sage\n    sage: CartanType(['A', NN])\n    ['A', NN]\n    sage: print(CartanType(['A', NN]).ascii_art())\n    O---O---O---O---O---O---O---..\n    0   1   2   3\n    sage: CartanType(['A', ZZ])\n    ['A', ZZ]\n    sage: print(CartanType(['A', ZZ]).ascii_art())\n    ..---O---O---O---O---O---O---O---..\n        -3  -2  -1   0   1   2   3\n\n```\nThere is now a `CartanType_standard` class in `cartan_type.py` but, to be honest, it does not save a great deal. I played round a little to try and rationalise the code but everything seems very tangled because small changes in one place cause errors elsewhere. I think that if the code is to the cleaned up then it needs to be done by some one who is more familiar with it and its' applications in sage.\n\nThe code works with 7.3.beta7 but it will almost certainly not merge on the next release on the develop branch given trac:18555.",
    "created_at": "2016-07-12T10:39:27Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304711",
    "user": "https://github.com/AndrewAtLarge"
}

comment:20

I have addressed all of the comments above. Given the ambiguity between oo and +oo I have used NN and ZZ throughout, although oo is a synonym for ZZ:

    sage: CartanType(['A', NN])
    ['A', NN]
    sage: print(CartanType(['A', NN]).ascii_art())
    O---O---O---O---O---O---O---..
    0   1   2   3
    sage: CartanType(['A', ZZ])
    ['A', ZZ]
    sage: print(CartanType(['A', ZZ]).ascii_art())
    ..---O---O---O---O---O---O---O---..
        -3  -2  -1   0   1   2   3

There is now a CartanType_standard class in cartan_type.py but, to be honest, it does not save a great deal. I played round a little to try and rationalise the code but everything seems very tangled because small changes in one place cause errors elsewhere. I think that if the code is to the cleaned up then it needs to be done by some one who is more familiar with it and its' applications in sage.

The code works with 7.3.beta7 but it will almost certainly not merge on the next release on the develop branch given trac:18555.

archive/issue_comments_304712.json:

{
    "body": "<div id=\"comment:21\" align=\"right\">comment:21</div>\n\nReplying to [@AndrewAtLarge](#comment%3A20):\n> I have addressed all of the comments above. Given the ambiguity between `oo` and `+oo` I have used `NN` and `ZZ` throughout, although `oo` is a synonym for `ZZ`:\n\nThat is exactly what I was just going to suggest this morning. :P I think this is the best way forward.\n\n> There is now a `CartanType_standard` class in `cartan_type.py` but, to be honest, it does not save a great deal. I played round a little to try and rationalise the code but everything seems very tangled because small changes in one place cause errors elsewhere. I think that if the code is to the cleaned up then it needs to be done by some one who is more familiar with it and its' applications in sage.\n\nYea, I remember them being fairly interconnected, sometimes in subtle ways. I remember fighting some things when I was trying to implement hyperbolic types (which I don't know when I will get back to this).\n\n> The code works with 7.3.beta7 but it will almost certainly not merge on the next release on the develop branch given trac:18555.\n\nIf #18555 really does cause a conflict, which I agree it probably does, then let's have a preemptive strike and base this over #18555.",
    "created_at": "2016-07-12T14:09:39Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304712",
    "user": "https://github.com/tscrim"
}

comment:21

Replying to @AndrewAtLarge:

I have addressed all of the comments above. Given the ambiguity between oo and +oo I have used NN and ZZ throughout, although oo is a synonym for ZZ:

That is exactly what I was just going to suggest this morning. :P I think this is the best way forward.

There is now a CartanType_standard class in cartan_type.py but, to be honest, it does not save a great deal. I played round a little to try and rationalise the code but everything seems very tangled because small changes in one place cause errors elsewhere. I think that if the code is to the cleaned up then it needs to be done by some one who is more familiar with it and its' applications in sage.

Yea, I remember them being fairly interconnected, sometimes in subtle ways. I remember fighting some things when I was trying to implement hyperbolic types (which I don't know when I will get back to this).

The code works with 7.3.beta7 but it will almost certainly not merge on the next release on the develop branch given trac:18555.

If #18555 really does cause a conflict, which I agree it probably does, then let's have a preemptive strike and base this over #18555.

archive/issue_comments_304713.json:

{
    "body": "<div id=\"comment:22\" align=\"right\">comment:22</div>\n\nAlso, this sentence is vague:\n\n```\n    In sage `oo` is the same as `+Infinity` so `NN` and `ZZ` are used to\n    differentiate between the `A_{+\\infty}` and `A_{\\infty}` root systems.\n```\nIn particular, what does `oo` do? I would write the entire docstring as:\n\n```python\nclass CartanType(CartanType_standard, CartanType_simple):\n    r\"\"\"\n    Define the Cartan type `A_{\\infty}`.\n\n    We use `NN` and `ZZ` to explicitly differentiate between the\n    `A_{+\\infty}` and `A_{\\infty}` root systems. While `oo` is\n    the same as `+Infinity` in Sage, it is used as an alias\n    for `ZZ`.\n    \"\"\"\n```\nI would also move all of the `EXAMPLES::` from the `__init__` into the class-level doc above (but leave the ones in `TESTS::` in `__init__`).",
    "created_at": "2016-07-12T14:13:10Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304713",
    "user": "https://github.com/tscrim"
}

comment:22

Also, this sentence is vague:

    In sage `oo` is the same as `+Infinity` so `NN` and `ZZ` are used to
    differentiate between the `A_{+\infty}` and `A_{\infty}` root systems.

In particular, what does oo do? I would write the entire docstring as:

class CartanType(CartanType_standard, CartanType_simple):
    r"""
    Define the Cartan type `A_{\infty}`.

    We use `NN` and `ZZ` to explicitly differentiate between the
    `A_{+\infty}` and `A_{\infty}` root systems. While `oo` is
    the same as `+Infinity` in Sage, it is used as an alias
    for `ZZ`.
    """

I would also move all of the EXAMPLES:: from the __init__ into the class-level doc above (but leave the ones in TESTS:: in __init__).

archive/issue_comments_304714.json:

{
    "body": "Changed commit from **[`3c53706`](https://github.com/sagemath/sagetrac-mirror/commit/3c5370673410e49fc0acbff86d1ba443c72a44a8)** to **[`c600b3c`](https://github.com/sagemath/sagetrac-mirror/commit/c600b3c2a3cc4f7c66968cca9ce6589d0d878992)**",
    "created_at": "2016-07-15T17:21:26Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304714",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 3c53706 to c600b3c

archive/issue_comments_304715.json:

{
    "body": "<div id=\"comment:23\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/5b02f0dfbf87f3871b3ee95ad8948ac0c666a45d\"><code>5b02f0d</code></a></td><td><code>Merge branch 'develop' into t/20973/cartan_type_aoo</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/c600b3c2a3cc4f7c66968cca9ce6589d0d878992\"><code>c600b3c</code></a></td><td><code>Updating doc-string for A_oo</code></td></tr></table>\n",
    "created_at": "2016-07-15T17:21:26Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304715",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

`5b02f0d`	`Merge branch 'develop' into t/20973/cartan_type_aoo`
`c600b3c`	`Updating doc-string for A_oo`

archive/issue_comments_304716.json:

{
    "body": "Reviewer: **Nicolas Thi\u00e9ry, Travis Scrimshaw**",
    "created_at": "2016-07-18T00:05:38Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304716",
    "user": "https://github.com/tscrim"
}

Reviewer: Nicolas Thiéry, Travis Scrimshaw

archive/issue_comments_304717.json:

{
    "body": "<div id=\"comment:24\" align=\"right\">comment:24</div>\n\nThanks for the changes. I made a few minor reviewer changes. If you're okay with them, then you can set a positive review.\n\n---\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/9cd615d8a61c85d294a2812ed0826a656232a215\"><code>9cd615d</code></a></td><td><code>Some small reviewer changes.</code></td></tr></table>\n",
    "created_at": "2016-07-18T00:05:38Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304717",
    "user": "https://github.com/tscrim"
}

comment:24

Thanks for the changes. I made a few minor reviewer changes. If you're okay with them, then you can set a positive review.

New commits:

9cd615d Some small reviewer changes.

archive/issue_comments_304718.json:

{
    "body": "Changed branch from **[u/andrew.mathas/cartan_type_aoo](https://github.com/sagemath/sagetrac-mirror/tree/u/andrew.mathas/cartan_type_aoo)** to **[public/combinat/root_system/type_A_infinity-20973](https://github.com/sagemath/sagetrac-mirror/tree/public/combinat/root_system/type_A_infinity-20973)**",
    "created_at": "2016-07-18T00:05:38Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304718",
    "user": "https://github.com/tscrim"
}

Changed branch from u/andrew.mathas/cartan_type_aoo to public/combinat/root_system/type_A_infinity-20973

archive/issue_comments_304719.json:

{
    "body": "Changed commit from **[`c600b3c`](https://github.com/sagemath/sagetrac-mirror/commit/c600b3c2a3cc4f7c66968cca9ce6589d0d878992)** to **[`9cd615d`](https://github.com/sagemath/sagetrac-mirror/commit/9cd615d8a61c85d294a2812ed0826a656232a215)**",
    "created_at": "2016-07-18T00:05:38Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304719",
    "user": "https://github.com/tscrim"
}

Changed commit from c600b3c to 9cd615d

archive/issue_comments_304720.json:

{
    "body": "<div id=\"comment:25\" align=\"right\">comment:25</div>\n\nThanks Travis. Yes, I am happy with your changes.",
    "created_at": "2016-07-20T16:55:10Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304720",
    "user": "https://github.com/AndrewAtLarge"
}

comment:25

Thanks Travis. Yes, I am happy with your changes.

archive/issue_events_292439.json:

{
    "actor": "https://github.com/AndrewAtLarge",
    "created_at": "2016-07-20T16:55:10Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20973#event-292439"
}

archive/issue_events_292440.json:

{
    "actor": "https://github.com/AndrewAtLarge",
    "created_at": "2016-07-20T16:55:10Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20973#event-292440"
}

archive/issue_events_292441.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-07-21T07:09:02Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20973#event-292441"
}

archive/issue_events_292442.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-07-21T07:09:02Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20973#event-292442"
}

archive/issue_comments_304721.json:

{
    "body": "<div id=\"comment:26\" align=\"right\">comment:26</div>\n\n\n```\nsage -t --long src/sage/algebras/nil_coxeter_algebra.py  # 1 doctest failed\nsage -t --long src/sage/combinat/root_system/cartan_type.py  # 1 doctest failed\nsage -t --long src/sage/combinat/root_system/dynkin_diagram.py  # 1 doctest failed\n```",
    "created_at": "2016-07-21T07:09:02Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304721",
    "user": "https://github.com/vbraun"
}

comment:26

sage -t --long src/sage/algebras/nil_coxeter_algebra.py  # 1 doctest failed
sage -t --long src/sage/combinat/root_system/cartan_type.py  # 1 doctest failed
sage -t --long src/sage/combinat/root_system/dynkin_diagram.py  # 1 doctest failed

archive/issue_comments_304722.json:

{
    "body": "<div id=\"comment:27\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/c1b57e673a66cb92d92acefa2cd6f86b236ca7f9\"><code>c1b57e6</code></a></td><td><code>Fixing broken doctests</code></td></tr></table>\n",
    "created_at": "2016-07-21T09:59:45Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304722",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

c1b57e6 Fixing broken doctests

archive/issue_comments_304723.json:

{
    "body": "Changed commit from **[`9cd615d`](https://github.com/sagemath/sagetrac-mirror/commit/9cd615d8a61c85d294a2812ed0826a656232a215)** to **[`c1b57e6`](https://github.com/sagemath/sagetrac-mirror/commit/c1b57e673a66cb92d92acefa2cd6f86b236ca7f9)**",
    "created_at": "2016-07-21T09:59:45Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304723",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 9cd615d to c1b57e6

archive/issue_comments_304724.json:

{
    "body": "<div id=\"comment:28\" align=\"right\">comment:28</div>\n\nSorry! All fixed.",
    "created_at": "2016-07-21T10:00:24Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304724",
    "user": "https://github.com/AndrewAtLarge"
}

comment:28

Sorry! All fixed.

archive/issue_events_292443.json:

{
    "actor": "https://github.com/AndrewAtLarge",
    "created_at": "2016-07-21T10:00:24Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20973#event-292443"
}

archive/issue_events_292444.json:

{
    "actor": "https://github.com/AndrewAtLarge",
    "created_at": "2016-07-21T10:00:24Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20973#event-292444"
}

archive/issue_comments_304725.json:

{
    "body": "Changed branch from **[public/combinat/root_system/type_A_infinity-20973](https://github.com/sagemath/sagetrac-mirror/tree/public/combinat/root_system/type_A_infinity-20973)** to **[`c1b57e6`](https://github.com/sagemath/sagetrac-mirror/commit/c1b57e673a66cb92d92acefa2cd6f86b236ca7f9)**",
    "created_at": "2016-07-22T06:50:49Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304725",
    "user": "https://github.com/vbraun"
}

Changed branch from public/combinat/root_system/type_A_infinity-20973 to c1b57e6

archive/issue_events_292445.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-07-22T06:50:49Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20973#event-292445"
}

archive/issue_events_292446.json:

{
    "actor": "https://github.com/vbraun",
    "commit_id": "8c6f3ecd771243ebaa907e6923a54ac2f7e9d93f",
    "commit_repository": "https://github.com/sagemath/sage",
    "created_at": "2016-07-22T06:50:49Z",
    "event": "closed",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20973#event-292446"
}

archive/issue_comments_304726.json:

{
    "body": "Changed reviewer from **Nicolas Thi\u00e9ry, Travis Scrimshaw** to **Nicolas M. Thi\u00e9ry, Travis Scrimshaw**",
    "created_at": "2016-08-16T11:33:45Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304726",
    "user": "https://github.com/jdemeyer"
}

Changed reviewer from Nicolas Thiéry, Travis Scrimshaw to Nicolas M. Thiéry, Travis Scrimshaw

archive/issue_comments_304727.json:

{
    "body": "Changed commit from **[`c1b57e6`](https://github.com/sagemath/sagetrac-mirror/commit/c1b57e673a66cb92d92acefa2cd6f86b236ca7f9)** to none",
    "created_at": "2016-08-16T11:33:45Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20973",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20973#issuecomment-304727",
    "user": "https://github.com/jdemeyer"
}

Changed commit from c1b57e6 to none

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

20973.md

20973.md

Issue 20973: Cartan type Aoo

Files

20973.md

Latest commit

History

20973.md

File metadata and controls

Issue 20973: Cartan type Aoo