archive/issues_020745.json:
{
"assignees": [],
"body": "<div id=\"comment:0\"></div>\n\nAs far as I can tell this builds fine. I think at the time this `spkg-install` was written Cygwin-64 just wasn't supported yet.\n\nI don't know whether or not there are any specific runtime issues with this. I don't have any reason to believe there are but I've still barely begun to crack into the failing tests on Cygwin.\n\nCC: @jpflori\n\nComponent: **porting: Cygwin**\n\nKeywords: **windows cygwin gmp, days85**\n\nAuthor: **Erik Bray**\n\nBranch/Commit: **[`f085eef`](https://github.com/sagemath/sagetrac-mirror/commit/f085eef1a946011daf3216465a75da7ffd6e9102)**\n\nReviewer: **Jeroen Demeyer**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20982_\n\n",
"closed_at": "2017-04-03T20:59:26Z",
"created_at": "2016-07-08T12:23:21Z",
"labels": [
"https://github.com/sagemath/sage/labels/c%3A%20porting%3A%20cygwin",
"https://github.com/sagemath/sage/labels/p%3A%20minor%20/%204",
"https://github.com/sagemath/sage/labels/enhancement"
],
"milestone": "https://github.com/sagemath/sage/milestones/sage-8.0",
"reactions": [],
"repository": "https://github.com/sagemath/sage",
"title": "Add support for building GMP with ABI=64 on 64-bit Cygwin",
"type": "issue",
"updated_at": "2017-04-03T20:59:26Z",
"url": "https://github.com/sagemath/sage/issues/20982",
"user": "https://github.com/embray"
}As far as I can tell this builds fine. I think at the time this spkg-install was written Cygwin-64 just wasn't supported yet.
I don't know whether or not there are any specific runtime issues with this. I don't have any reason to believe there are but I've still barely begun to crack into the failing tests on Cygwin.
CC: @jpflori
Component: porting: Cygwin
Keywords: windows cygwin gmp, days85
Author: Erik Bray
Branch/Commit: f085eef
Reviewer: Jeroen Demeyer
Issue created by migration from https://trac.sagemath.org/ticket/20982
archive/issue_events_292551.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-07-08T12:23:21Z",
"event": "milestoned",
"issue": "https://github.com/sagemath/sage/issues/20982",
"milestone_number": null,
"milestone_title": "sage-7.3",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20982#event-292551"
}archive/issue_events_292552.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-07-08T12:23:21Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20982",
"label": "https://github.com/sagemath/sage/labels/p%3A%20minor%20/%204",
"label_color": "ffe799",
"label_name": "p: minor / 4",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20982#event-292552"
}archive/issue_events_292553.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-07-08T12:23:21Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20982",
"label": "https://github.com/sagemath/sage/labels/enhancement",
"label_color": "696969",
"label_name": "enhancement",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20982#event-292553"
}archive/issue_events_292554.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-07-08T12:23:21Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20982",
"label": "https://github.com/sagemath/sage/labels/c%3A%20porting%3A%20cygwin",
"label_color": "0000b0",
"label_name": "c: porting: cygwin",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20982#event-292554"
}archive/issue_events_292555.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-07-08T12:23:32Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20982",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20982#event-292555"
}archive/issue_comments_304826.json:
{
"body": "<div id=\"comment:3\" align=\"right\">comment:3</div>\n\nDo we really need to hardcode the `ABI` value? Doesn't GMP auto-detect this?",
"created_at": "2017-03-16T19:10:14Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20982",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20982#issuecomment-304826",
"user": "https://github.com/jdemeyer"
}comment:3
Do we really need to hardcode the ABI value? Doesn't GMP auto-detect this?
archive/issue_comments_304827.json:
{
"body": "<div id=\"comment:4\" align=\"right\">comment:4</div>\n\nMaybe at that time Cygwin64 was not officialy supported and some \"*cygwin*\" regexp forced 32 bits builds.\nIt might be the case things have changed...",
"created_at": "2017-03-16T19:48:44Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20982",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20982#issuecomment-304827",
"user": "https://github.com/jpflori"
}comment:4
Maybe at that time Cygwin64 was not officialy supported and some "cygwin" regexp forced 32 bits builds. It might be the case things have changed...
archive/issue_comments_304828.json:
{
"body": "<div id=\"comment:5\" align=\"right\">comment:5</div>\n\nNo, I don't think it's necessary anymore.",
"created_at": "2017-03-16T19:49:40Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20982",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20982#issuecomment-304828",
"user": "https://github.com/embray"
}comment:5
No, I don't think it's necessary anymore.
archive/issue_comments_304829.json:
{
"body": "<div id=\"comment:6\" align=\"right\">comment:6</div>\n\nIn other words, I could update this patch to just remove that case entirely.",
"created_at": "2017-03-16T19:50:24Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20982",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20982#issuecomment-304829",
"user": "https://github.com/embray"
}comment:6
In other words, I could update this patch to just remove that case entirely.
archive/issue_comments_304830.json:
{
"body": "<div id=\"comment:7\"></div>\n\nBranch pushed to git repo; I updated commit sha1. This was a forced push. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/f085eef1a946011daf3216465a75da7ffd6e9102\"><code>f085eef</code></a></td><td><code>Add Cygwin-64 support for gmp by not forcing ABI=32</code></td></tr></table>\n",
"created_at": "2017-03-16T21:16:03Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20982",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20982#issuecomment-304830",
"user": "https://github.com/sagetrac-git"
}Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
f085eef | Add Cygwin-64 support for gmp by not forcing ABI=32 |
archive/issue_comments_304831.json:
{
"body": "Changed commit from **[`5a627bb`](https://github.com/sagemath/sagetrac-mirror/commit/5a627bb44c3948820f917a458fd3470125abd9b8)** to **[`f085eef`](https://github.com/sagemath/sagetrac-mirror/commit/f085eef1a946011daf3216465a75da7ffd6e9102)**",
"created_at": "2017-03-16T21:16:03Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20982",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20982#issuecomment-304831",
"user": "https://github.com/sagetrac-git"
}Changed commit from 5a627bb to f085eef
archive/issue_comments_304832.json:
{
"body": "<div id=\"comment:8\" align=\"right\">comment:8</div>\n\nOkay, I've confirmed manually setting `ABI` is not necessary at all for 64-bit builds (or likely not 32 for that matter). So I redid the branch to just remove the case for Cygwin entirely.",
"created_at": "2017-03-16T21:17:00Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20982",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20982#issuecomment-304832",
"user": "https://github.com/embray"
}comment:8
Okay, I've confirmed manually setting ABI is not necessary at all for 64-bit builds (or likely not 32 for that matter). So I redid the branch to just remove the case for Cygwin entirely.
archive/issue_events_292556.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2017-03-17T08:55:26Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20982",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20982#event-292556"
}archive/issue_events_292557.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2017-03-17T08:55:26Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20982",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20982#event-292557"
}archive/issue_comments_304833.json:
{
"body": "Reviewer: **Jeroen Demeyer**",
"created_at": "2017-03-17T08:55:26Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20982",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20982#issuecomment-304833",
"user": "https://github.com/jdemeyer"
}Reviewer: Jeroen Demeyer
archive/issue_comments_304834.json:
{
"body": "Changed keywords from **windows cygwin gmp** to **windows cygwin gmp, days85**",
"created_at": "2017-03-17T09:03:15Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20982",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20982#issuecomment-304834",
"user": "https://github.com/tscrim"
}Changed keywords from windows cygwin gmp to windows cygwin gmp, days85
archive/issue_events_292558.json:
{
"actor": "https://github.com/tscrim",
"created_at": "2017-03-17T09:03:15Z",
"event": "demilestoned",
"issue": "https://github.com/sagemath/sage/issues/20982",
"milestone_number": null,
"milestone_title": "sage-7.3",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20982#event-292558"
}archive/issue_events_292559.json:
{
"actor": "https://github.com/tscrim",
"created_at": "2017-03-17T09:03:15Z",
"event": "milestoned",
"issue": "https://github.com/sagemath/sage/issues/20982",
"milestone_number": null,
"milestone_title": "sage-8.0",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20982#event-292559"
}archive/issue_comments_304835.json:
{
"body": "Changed branch from **[u/embray/cygwin-64-gmp](https://github.com/sagemath/sagetrac-mirror/tree/u/embray/cygwin-64-gmp)** to **[`f085eef`](https://github.com/sagemath/sagetrac-mirror/commit/f085eef1a946011daf3216465a75da7ffd6e9102)**",
"created_at": "2017-04-03T20:59:26Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20982",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20982#issuecomment-304835",
"user": "https://github.com/vbraun"
}Changed branch from u/embray/cygwin-64-gmp to f085eef
archive/issue_events_292560.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2017-04-03T20:59:26Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20982",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20982#event-292560"
}archive/issue_events_292561.json:
{
"actor": "https://github.com/vbraun",
"commit_id": "6a3011770d4ef73749b276bfe66b6c83fe71b121",
"commit_repository": "https://github.com/sagemath/sage",
"created_at": "2017-04-03T20:59:26Z",
"event": "closed",
"issue": "https://github.com/sagemath/sage/issues/20982",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20982#event-292561"
}