archive/issues_020750.json:
{
"assignees": [],
"body": "<div id=\"comment:0\"></div>\n\nFix a bit of slight sloppiness in variable usage.\n\nThe `'atlas' in libs` line should really be `'atlas' in libraries`\nThis was still working due to Python's loop variable leakage, but\nfrom the logic it's clear that the `libraries` variable was intended\nto be used here.\n\nI can't remember whether this actually caused a bug or not. I don't think so though.\n\nComponent: **packages: standard**\n\nAuthor: **Erik Bray**\n\nBranch/Commit: **[`5384da6`](https://github.com/sagemath/sagetrac-mirror/commit/5384da6cdfec62a59c8f9b9acc8596d38e178037)**\n\nReviewer: **Fr\u00e9d\u00e9ric Chapoton**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20987_\n\n",
"closed_at": "2016-07-12T07:25:12Z",
"created_at": "2016-07-08T13:36:31Z",
"labels": [
"https://github.com/sagemath/sage/labels/c%3A%20packages%3A%20standard",
"https://github.com/sagemath/sage/labels/p%3A%20trivial%20/%205",
"https://github.com/sagemath/sage/labels/bug"
],
"milestone": "https://github.com/sagemath/sage/milestones/sage-7.3",
"reactions": [],
"repository": "https://github.com/sagemath/sage",
"title": "Minor logic fix in spkg-install for atlas",
"type": "issue",
"updated_at": "2016-07-12T07:25:12Z",
"url": "https://github.com/sagemath/sage/issues/20987",
"user": "https://github.com/embray"
}Fix a bit of slight sloppiness in variable usage.
The 'atlas' in libs line should really be 'atlas' in libraries
This was still working due to Python's loop variable leakage, but
from the logic it's clear that the libraries variable was intended
to be used here.
I can't remember whether this actually caused a bug or not. I don't think so though.
Component: packages: standard
Author: Erik Bray
Branch/Commit: 5384da6
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/20987
archive/issue_events_292610.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-07-08T13:36:31Z",
"event": "milestoned",
"issue": "https://github.com/sagemath/sage/issues/20987",
"milestone_number": null,
"milestone_title": "sage-7.3",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20987#event-292610"
}archive/issue_events_292611.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-07-08T13:36:31Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20987",
"label": "https://github.com/sagemath/sage/labels/c%3A%20packages%3A%20standard",
"label_color": "0000b0",
"label_name": "c: packages: standard",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20987#event-292611"
}archive/issue_events_292612.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-07-08T13:36:31Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20987",
"label": "https://github.com/sagemath/sage/labels/p%3A%20trivial%20/%205",
"label_color": "fff9e5",
"label_name": "p: trivial / 5",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20987#event-292612"
}archive/issue_events_292613.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-07-08T13:36:31Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20987",
"label": "https://github.com/sagemath/sage/labels/bug",
"label_color": "d73a4a",
"label_name": "bug",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20987#event-292613"
}archive/issue_events_292614.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-07-08T13:36:46Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20987",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20987#event-292614"
}archive/issue_comments_304875.json:
{
"body": "Reviewer: **Fr\u00e9d\u00e9ric Chapoton**",
"created_at": "2016-07-11T08:55:30Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20987",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20987#issuecomment-304875",
"user": "https://github.com/fchapoton"
}Reviewer: Frédéric Chapoton
archive/issue_events_292615.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-07-11T08:55:30Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20987",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20987#event-292615"
}archive/issue_events_292616.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-07-11T08:55:30Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20987",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20987#event-292616"
}archive/issue_comments_304876.json:
{
"body": "<div id=\"comment:2\" align=\"right\">comment:2</div>\n\nok, lgtm",
"created_at": "2016-07-11T08:55:30Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20987",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20987#issuecomment-304876",
"user": "https://github.com/fchapoton"
}comment:2
ok, lgtm
archive/issue_comments_304877.json:
{
"body": "Changed branch from **[u/embray/atlas-spkg-install-buglet](https://github.com/sagemath/sagetrac-mirror/tree/u/embray/atlas-spkg-install-buglet)** to **[`5384da6`](https://github.com/sagemath/sagetrac-mirror/commit/5384da6cdfec62a59c8f9b9acc8596d38e178037)**",
"created_at": "2016-07-12T07:25:12Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20987",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20987#issuecomment-304877",
"user": "https://github.com/vbraun"
}Changed branch from u/embray/atlas-spkg-install-buglet to 5384da6
archive/issue_events_292617.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-07-12T07:25:12Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20987",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20987#event-292617"
}archive/issue_events_292618.json:
{
"actor": "https://github.com/vbraun",
"commit_id": "32199ef2ff1e8a0096706178cae8a432230840b2",
"commit_repository": "https://github.com/sagemath/sage",
"created_at": "2016-07-12T07:25:12Z",
"event": "closed",
"issue": "https://github.com/sagemath/sage/issues/20987",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20987#event-292618"
}