Skip to content

Commit 058a96d

Browse files
sam-githubTrott
authored andcommitted
tls: re-define max supported version as 1.2
Several secureProtocol strings allow any supported TLS version as the maximum, but our maximum supported protocol version is TLSv1.2 even if someone configures a build against an OpenSSL that supports TLSv1.3. Fixes: nodejs#24658
1 parent 3439c95 commit 058a96d

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/node_crypto.cc

+6
Original file line numberDiff line numberDiff line change
@@ -518,6 +518,12 @@ void SecureContext::Init(const FunctionCallbackInfo<Value>& args) {
518518
SSL_SESS_CACHE_NO_AUTO_CLEAR);
519519

520520
SSL_CTX_set_min_proto_version(sc->ctx_.get(), min_version);
521+
522+
if (max_version == 0) {
523+
// Selecting some secureProtocol methods allows the TLS version to be "any
524+
// supported", but we don't support TLSv1.3, even if OpenSSL does.
525+
max_version = TLS1_2_VERSION;
526+
}
521527
SSL_CTX_set_max_proto_version(sc->ctx_.get(), max_version);
522528

523529
// OpenSSL 1.1.0 changed the ticket key size, but the OpenSSL 1.0.x size was

0 commit comments

Comments
 (0)