Skip to content

Commit 8e411a2

Browse files
ntkmenex3
andauthoredFeb 27, 2025
Use thread-safe writeln from dart sdk >=3.6.0 (#2528)
Co-authored-by: Natalie Weizenbaum <[email protected]>
1 parent 37b66a1 commit 8e411a2

File tree

4 files changed

+7
-14
lines changed

4 files changed

+7
-14
lines changed
 

‎CHANGELOG.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
## 1.85.2-dev
22

3-
* No user-visible changes.
3+
### Dart API
4+
5+
* Increase the minimum Dart SDK to 3.6.0.
46

57
## 1.85.1
68

‎lib/src/io/vm.dart

+2-11
Original file line numberDiff line numberDiff line change
@@ -32,20 +32,11 @@ bool get supportsAnsiEscapes {
3232
}
3333

3434
void safePrint(Object? message) {
35-
_threadSafeWriteLn(io.stdout, message);
35+
print(message);
3636
}
3737

3838
void printError(Object? message) {
39-
_threadSafeWriteLn(io.stderr, message);
40-
}
41-
42-
void _threadSafeWriteLn(io.IOSink sink, Object? message) {
43-
// This does have performance penality of copying buffer
44-
// if message is already a StringBuffer.
45-
// https://github.com/dart-lang/sdk/issues/53471.
46-
var buffer = StringBuffer(message.toString());
47-
buffer.writeln();
48-
sink.write(buffer);
39+
io.stderr.writeln(message);
4940
}
5041

5142
String readFile(String path) {

‎pkg/sass_api/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ description: Additional APIs for Dart Sass.
77
homepage: https://github.com/sass/dart-sass
88

99
environment:
10-
sdk: ">=3.3.0 <4.0.0"
10+
sdk: ">=3.6.0 <4.0.0"
1111

1212
dependencies:
1313
sass: 1.85.2

‎pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ executables:
88
sass: sass
99

1010
environment:
11-
sdk: ">=3.3.0 <4.0.0"
11+
sdk: ">=3.6.0 <4.0.0"
1212

1313
dependencies:
1414
args: ^2.0.0

0 commit comments

Comments
 (0)