Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMSSerializerBundle 2.0 minimum requirements #561

Closed
goetas opened this issue Apr 3, 2017 · 3 comments
Closed

JMSSerializerBundle 2.0 minimum requirements #561

goetas opened this issue Apr 3, 2017 · 3 comments
Labels
Milestone

Comments

@goetas
Copy link
Collaborator

goetas commented Apr 3, 2017

In JMSSerializerBundle 2.0 I'm planning to drop support for:

  • PHP 5.X versions. This means only 7.x will be supported
  • Symfony 2.x version. This means only 3.x (and most probably 4.x) will be supported
  • Complete HHVM support drop

HHVM was looking to be a pretty important project, but after PHP7 show up, HHVM faded a bit. It this true or is just my impression?

see 2.0...2.0-min-deps

Any feedback on this decision?

(Backward incompatible changes between 1.x and 2.0 are in UPGRADING.md)

@goetas goetas added the question label Apr 3, 2017
@goetas goetas added this to the v2.0 milestone Apr 3, 2017
@lbayerl
Copy link

lbayerl commented Apr 12, 2017

looks fine - but is there any specific usage of PHP 7 functionality? because usually I don't see why 5.6 shouldn't be supported as long it's supported and there's no need to use new language features in the bundle

@goetas
Copy link
Collaborator Author

goetas commented Apr 12, 2017

the initial idea was to have a chance to add new features to the serializer using new php7 improvements in the subsequent 2.x releases...

but looking at the development in the serializer 2.0, i was considering keeping the bundle compatibile with 5.6 at least

Anyway the bundle does really few things, so being compatible with the widest set of php versions might be a good idea

@goetas goetas mentioned this issue May 5, 2017
@goetas
Copy link
Collaborator Author

goetas commented May 10, 2017

decided to stay with the current minimum requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants