-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(colors, highlights): improved NonText
readability
#74
feat(colors, highlights): improved NonText
readability
#74
Conversation
I force pushed cause I don't know how (87aee45) got in the PR while I was writing it 🤔 |
Wow @AlejandroSuero ! Appreciate all the work you're putting in on these PRs! I think this is a very necessary change and should be fixed. However, I think we should try and make it work without affecting the base palette. As you can probably already tell, this has the knock-on effect of updating all of the extras that reference it. You can use the |
@scottmckendry okay, I will play around to get a feel to mix the base palette. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still showing lots of changes to extras, I think there still may be changes in colors.lua
that differ from main
. Can you check, please? Thanks!
@scottmckendry This has nothing to do with this PR but while I was playing around with the values, I used Telescope a lot and notice that there is no contrast between search and results and preview. Here is my proposal.
![]()
![]() |
Okay I am going to copy the main branch colors. |
@scottmckendry now it only changes 1 files, I check the colour contrast and still works correctly both in light and dark |
@AlejandroSuero the blue looks quite nice. Do you have this change in a branch? Would like to see how it looks in person :) |
@scottmckendry a little tweak on the colours and the highlights to improve readability when using
NonText
andNonText+CursorLine
. Usually used by AI plugins and terminal based plugins to show "ghost text".Warning
Toggling light and dark 💥
Screen.Recording.2024-06-15.at.00.26.19.mov
Using
:term
:Screen.Recording.2024-06-15.at.00.11.38.mov
Screen.Recording.2024-06-15.at.00.25.24.mov
Using
:term
: