Skip to content

Commit 162ef11

Browse files
Merge pull request #548 from jozic/properly-handle-multiple-exclude-entries-for-scala3
Properly handle multiple exclude entries for Scala 3
2 parents 9a0b190 + c3211b8 commit 162ef11

File tree

5 files changed

+22
-4
lines changed

5 files changed

+22
-4
lines changed

src/main/scala/scoverage/ScoverageSbtPlugin.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -197,15 +197,15 @@ object ScoverageSbtPlugin extends AutoPlugin {
197197
if isScala3SupportingFilePackageExclusion(
198198
scalaVersion.value
199199
) =>
200-
s"-coverage-exclude-classlikes:$v"
200+
s"-coverage-exclude-classlikes:${v.replace(';', ',')}"
201201
},
202202
excludedFiles
203203
.collect {
204204
case v
205205
if isScala3SupportingFilePackageExclusion(
206206
scalaVersion.value
207207
) =>
208-
s"-coverage-exclude-files:$v"
208+
s"-coverage-exclude-files:${v.replace(';', ',')}"
209209
}
210210
).flatten
211211
} else if (coverageEnabled.value && !isScala2(scalaVersion.value)) {

src/sbt-test/scoverage/scala3-coverage-excluded-files/build.sbt

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ scalaVersion := "3.4.2"
44

55
libraryDependencies += "org.scalameta" %% "munit" % "0.7.29" % Test
66

7-
coverageExcludedFiles := ".*/two/GoodCoverage"
7+
coverageExcludedFiles := ".*/two/GoodCoverage;.*/three/GoodCoverage"
88

99
resolvers ++= {
1010
if (sys.props.get("plugin.version").exists(_.endsWith("-SNAPSHOT")))
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
package three
2+
3+
object GoodCoverage {
4+
5+
def sum(num1: Int, num2: Int) = {
6+
if (0 == num1) num2 else if (0 == num2) num1 else num1 + num2
7+
}
8+
9+
}

src/sbt-test/scoverage/scala3-coverage-excluded-packages/build.sbt

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ scalaVersion := "3.4.2"
44

55
libraryDependencies += "org.scalameta" %% "munit" % "0.7.29" % Test
66

7-
coverageExcludedPackages := "two\\..*"
7+
coverageExcludedPackages := "two\\..*;three\\..*"
88

99
resolvers ++= {
1010
if (sys.props.get("plugin.version").exists(_.endsWith("-SNAPSHOT")))
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
package three
2+
3+
object GoodCoverage {
4+
5+
def sum(num1: Int, num2: Int) = {
6+
if (0 == num1) num2 else if (0 == num2) num1 else num1 + num2
7+
}
8+
9+
}

0 commit comments

Comments
 (0)