Skip to content

Commit 1feee44

Browse files
authored
Cleans up BB API usage for config handling (#708)
1 parent 33aa4e2 commit 1feee44

File tree

5 files changed

+6
-8
lines changed

5 files changed

+6
-8
lines changed

varats-core/setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
setup_requires=["pytest-runner", "setuptools_scm"],
1111
tests_require=["pytest", "pytest-cov"],
1212
install_requires=[
13-
"benchbuild>=6.5.0",
13+
"benchbuild>=6.5.1",
1414
"plumbum>=1.6.6",
1515
"PyGithub>=1.47",
1616
"PyDriller>=2.0",

varats-core/varats/project/sources.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,10 @@ class FeatureSource(bb.source.FetchableSource): # type: ignore
1616

1717
LOCAL_KEY = "config_info"
1818

19-
def __init__(self, version: str) -> None:
20-
super().__init__(local=self.LOCAL_KEY, remote={version: "dummy_value"})
19+
def __init__(self) -> None:
20+
super().__init__(local=self.LOCAL_KEY, remote={"fv_1": "dummy_value"})
2121

2222
def version(self, target_dir: str, version: str) -> pb.LocalPath:
23-
# TODO: do we need this? Maybe an optional path?
2423
return pb.LocalPath('.')
2524

2625
def versions(self) -> tp.List[Variant]:

varats/setup.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@
1818
tests_require=["pytest", "pytest-cov"],
1919
install_requires=[
2020
"argparse-utils>=1.2.0",
21-
"benchbuild>=6.5.0",
22-
"dill==0.3.4", # Missing BB dep
21+
"benchbuild>=6.5.1",
2322
"click>=8.0.2",
2423
"distro>=1.5.0",
2524
"graphviz>=0.14.2",

varats/varats/projects/c_projects/xz.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ class Xz(VProject):
6363
shallow=False
6464
)
6565
),
66-
FeatureSource(version="1.0"),
66+
FeatureSource(),
6767
# TODO: auto unzipper for BB?
6868
HTTP(
6969
local="countries-land-1km.geo.json",

varats/varats/projects/perf_tests/feature_perf_cs_collection.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class FeaturePerfCSCollection(VProject):
3939
shallow=False,
4040
version_filter=project_filter_generator("FeaturePerfCSCollection")
4141
),
42-
FeatureSource(version="1.0")
42+
FeatureSource()
4343
]
4444

4545
WORKLOADS = {

0 commit comments

Comments
 (0)