Skip to content

Commit 2c52441

Browse files
Revert "Reduce unnecessary IO"
This reverts commit c41f730.
1 parent 0f46512 commit 2c52441

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

src/Data/RawCodeCoverageData.php

+9-5
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,10 @@
1616
use function array_intersect_key;
1717
use function array_map;
1818
use function count;
19-
use function file;
19+
use function explode;
20+
use function file_get_contents;
2021
use function in_array;
22+
use function is_file;
2123
use function preg_replace;
2224
use function range;
2325
use function str_ends_with;
@@ -267,11 +269,13 @@ private function getEmptyLinesForFile(string $filename): array
267269
if (!isset(self::$emptyLineCache[$filename])) {
268270
self::$emptyLineCache[$filename] = [];
269271

270-
$sourceLines = @file($filename) ?: [];
272+
if (is_file($filename)) {
273+
$sourceLines = explode("\n", file_get_contents($filename));
271274

272-
foreach ($sourceLines as $line => $source) {
273-
if (trim($source) === '') {
274-
self::$emptyLineCache[$filename][] = ($line + 1);
275+
foreach ($sourceLines as $line => $source) {
276+
if (trim($source) === '') {
277+
self::$emptyLineCache[$filename][] = ($line + 1);
278+
}
275279
}
276280
}
277281
}

src/StaticAnalysis/CachingFileAnalyser.php

+3-4
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
use function file_get_contents;
1414
use function file_put_contents;
1515
use function implode;
16+
use function is_file;
1617
use function md5;
1718
use function serialize;
1819
use function unserialize;
@@ -168,14 +169,12 @@ private function read(string $filename): array|false
168169
{
169170
$cacheFile = $this->cacheFile($filename);
170171

171-
$contents = @file_get_contents($cacheFile);
172-
173-
if ($contents === false) {
172+
if (!is_file($cacheFile)) {
174173
return false;
175174
}
176175

177176
return unserialize(
178-
$contents,
177+
file_get_contents($cacheFile),
179178
[
180179
'allowed_classes' => [
181180
Class_::class,

0 commit comments

Comments
 (0)