Refactor

Author: sebastianbergmann

src/Directory.php

@@ -0,0 +1,18 @@
+<?php declare(strict_types=1);
+/*
+ * This file is part of phpunit/php-code-coverage.
+ *
+ * (c) Sebastian Bergmann <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace SebastianBergmann\CodeCoverage;
+
+final class Directory
+{
+    public static function create(string $directory): bool
+    {
+        return !(!\is_dir($directory) && !@\mkdir($directory, 0777, true) && !\is_dir($directory));
+    }
+}

src/Report/Clover.php

@@ -10,6 +10,7 @@
 namespace SebastianBergmann\CodeCoverage\Report;
 
 use SebastianBergmann\CodeCoverage\CodeCoverage;
+use SebastianBergmann\CodeCoverage\Directory;
 use SebastianBergmann\CodeCoverage\Node\File;
 use SebastianBergmann\CodeCoverage\RuntimeException;
 
@@ -236,7 +237,7 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
         $buffer = $xmlDocument->saveXML();
 
         if ($target !== null) {
-            if (!$this->createDirectory(\dirname($target))) {
+            if (!Directory::create(\dirname($target))) {
                 throw new \RuntimeException(\sprintf('Directory "%s" was not created', \dirname($target)));
             }
 
@@ -252,9 +253,4 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
 
         return $buffer;
     }
-
-    private function createDirectory(string $directory): bool
-    {
-        return !(!\is_dir($directory) && !@\mkdir($directory, 0777, true) && !\is_dir($directory));
-    }
 }

src/Report/Crap4j.php

@@ -10,6 +10,7 @@
 namespace SebastianBergmann\CodeCoverage\Report;
 
 use SebastianBergmann\CodeCoverage\CodeCoverage;
+use SebastianBergmann\CodeCoverage\Directory;
 use SebastianBergmann\CodeCoverage\Node\File;
 use SebastianBergmann\CodeCoverage\RuntimeException;
 
@@ -116,7 +117,7 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
         $buffer = $document->saveXML();
 
         if ($target !== null) {
-            if (!$this->createDirectory(\dirname($target))) {
+            if (!Directory::create(\dirname($target))) {
                 throw new \RuntimeException(\sprintf('Directory "%s" was not created', \dirname($target)));
             }
 
@@ -149,9 +150,4 @@ private function roundValue(float $value): float
     {
         return \round($value, 2);
     }
-
-    private function createDirectory(string $directory): bool
-    {
-        return !(!\is_dir($directory) && !@\mkdir($directory, 0777, true) && !\is_dir($directory));
-    }
 }

src/Report/Html/Facade.php

@@ -10,6 +10,7 @@
 namespace SebastianBergmann\CodeCoverage\Report\Html;
 
 use SebastianBergmann\CodeCoverage\CodeCoverage;
+use SebastianBergmann\CodeCoverage\Directory as DirectoryUtil;
 use SebastianBergmann\CodeCoverage\Node\Directory as DirectoryNode;
 use SebastianBergmann\CodeCoverage\RuntimeException;
 
@@ -89,7 +90,7 @@ public function process(CodeCoverage $coverage, string $target): void
             $id = $node->getId();
 
             if ($node instanceof DirectoryNode) {
-                if (!$this->createDirectory($target . $id)) {
+                if (!DirectoryUtil::create($target . $id)) {
                     throw new \RuntimeException(\sprintf('Directory "%s" was not created', $target . $id));
                 }
 
@@ -98,7 +99,7 @@ public function process(CodeCoverage $coverage, string $target): void
             } else {
                 $dir = \dirname($target . $id);
 
-                if (!$this->createDirectory($dir)) {
+                if (!DirectoryUtil::create($dir)) {
                     throw new \RuntimeException(\sprintf('Directory "%s" was not created', $dir));
                 }
 
@@ -144,7 +145,7 @@ private function getDirectory(string $directory): string
             $directory .= \DIRECTORY_SEPARATOR;
         }
 
-        if (!$this->createDirectory($directory)) {
+        if (!DirectoryUtil::create($directory)) {
             throw new RuntimeException(
                 \sprintf(
                     'Directory "%s" does not exist.',
@@ -155,9 +156,4 @@ private function getDirectory(string $directory): string
 
         return $directory;
     }
-
-    private function createDirectory(string $directory): bool
-    {
-        return !(!\is_dir($directory) && !@\mkdir($directory, 0777, true) && !\is_dir($directory));
-    }
 }

src/Report/PHP.php

@@ -10,6 +10,7 @@
 namespace SebastianBergmann\CodeCoverage\Report;
 
 use SebastianBergmann\CodeCoverage\CodeCoverage;
+use SebastianBergmann\CodeCoverage\Directory;
 use SebastianBergmann\CodeCoverage\RuntimeException;
 
 /**
@@ -40,7 +41,7 @@ public function process(CodeCoverage $coverage, ?string $target = null): string
         );
 
         if ($target !== null) {
-            if (!$this->createDirectory(\dirname($target))) {
+            if (!Directory::create(\dirname($target))) {
                 throw new \RuntimeException(\sprintf('Directory "%s" was not created', \dirname($target)));
             }
 
@@ -56,9 +57,4 @@ public function process(CodeCoverage $coverage, ?string $target = null): string
 
         return $buffer;
     }
-
-    private function createDirectory(string $directory): bool
-    {
-        return !(!\is_dir($directory) && !@\mkdir($directory, 0777, true) && !\is_dir($directory));
-    }
 }

src/Report/Xml/Facade.php

@@ -10,6 +10,7 @@
 namespace SebastianBergmann\CodeCoverage\Report\Xml;
 
 use SebastianBergmann\CodeCoverage\CodeCoverage;
+use SebastianBergmann\CodeCoverage\Directory as DirectoryUtil;
 use SebastianBergmann\CodeCoverage\Node\AbstractNode;
 use SebastianBergmann\CodeCoverage\Node\Directory as DirectoryNode;
 use SebastianBergmann\CodeCoverage\Node\File as FileNode;
@@ -89,7 +90,7 @@ private function initTargetDirectory(string $directory): void
                     "'$directory' exists but is not writable."
                 );
             }
-        } elseif (!$this->createDirectory($directory)) {
+        } elseif (!DirectoryUtil::create($directory)) {
             throw new RuntimeException(
                 "'$directory' could not be created."
             );
@@ -280,9 +281,4 @@ private function saveDocument(\DOMDocument $document, string $name): void
         /* @see https://bugs.php.net/bug.php?id=79191 */
         \file_put_contents($filename, $document->saveXML());
     }
-
-    private function createDirectory(string $directory): bool
-    {
-        return !(!\is_dir($directory) && !@\mkdir($directory, 0777, true) && !\is_dir($directory));
-    }
 }