Skip to content

Commit f819e0c

Browse files
Closes #731
1 parent 65dabf5 commit f819e0c

File tree

2 files changed

+16
-7
lines changed

2 files changed

+16
-7
lines changed

ChangeLog.md

+8-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22

33
All notable changes are documented in this file using the [Keep a CHANGELOG](http://keepachangelog.com/) principles.
44

5+
## [8.0.1] - 2020-MM-DD
6+
7+
### Fixed
8+
9+
* Fixed [#731](https://github.com/sebastianbergmann/php-code-coverage/pull/731): Confusing footer in the HTML report
10+
511
## [8.0.0] - 2020-02-07
612

713
### Fixed
@@ -122,7 +128,8 @@ All notable changes are documented in this file using the [Keep a CHANGELOG](htt
122128
* Class names are now abbreviated (unqualified name shown, fully qualified name shown on hover) in the file view of the HTML report
123129
* Update HTML report to Bootstrap 4
124130

125-
[8.0.0]: https://github.com/sebastianbergmann/php-code-coverage/compare/7.0.10...master
131+
[8.0.1]: https://github.com/sebastianbergmann/php-code-coverage/compare/8.0.0...master
132+
[8.0.0]: https://github.com/sebastianbergmann/php-code-coverage/compare/7.0.10...8.0.0
126133
[7.0.10]: https://github.com/sebastianbergmann/php-code-coverage/compare/7.0.9...7.0.10
127134
[7.0.9]: https://github.com/sebastianbergmann/php-code-coverage/compare/7.0.8...7.0.9
128135
[7.0.8]: https://github.com/sebastianbergmann/php-code-coverage/compare/7.0.7...7.0.8

src/Report/Html/Renderer.php

+8-6
Original file line numberDiff line numberDiff line change
@@ -259,18 +259,20 @@ private function getRuntimeString(): string
259259
$runtime->getVersion()
260260
);
261261

262-
if ($runtime->hasXdebug() && !$runtime->hasPHPDBGCodeCoverage()) {
263-
$buffer .= \sprintf(
264-
' with <a href="https://xdebug.org/">Xdebug %s</a>',
265-
\phpversion('xdebug')
266-
);
262+
if ($runtime->hasPHPDBGCodeCoverage()) {
263+
return $buffer;
267264
}
268265

269-
if ($runtime->hasPCOV() && !$runtime->hasPHPDBGCodeCoverage()) {
266+
if ($runtime->hasPCOV()) {
270267
$buffer .= \sprintf(
271268
' with <a href="https://github.com/krakjoe/pcov">PCOV %s</a>',
272269
\phpversion('pcov')
273270
);
271+
} elseif ($runtime->hasXdebug()) {
272+
$buffer .= \sprintf(
273+
' with <a href="https://xdebug.org/">Xdebug %s</a>',
274+
\phpversion('xdebug')
275+
);
274276
}
275277

276278
return $buffer;

0 commit comments

Comments
 (0)