Skip to content

Commit 038141b

Browse files
authored
[dotnet] Extend invalid selenium manager process exit codes (#11361)
Extend invalid selenium manager process exit codes
1 parent 397ecec commit 038141b

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

dotnet/src/webdriver/SeleniumManager.cs

+19-19
Original file line numberDiff line numberDiff line change
@@ -73,24 +73,24 @@ private static string Binary
7373
if (string.IsNullOrEmpty(binary))
7474
{
7575
#if NET45 || NET46 || NET47
76-
binary = "selenium-manager/windows/selenium-manager.exe";
76+
binary = "selenium-manager/windows/selenium-manager.exe";
7777
#else
78-
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
79-
{
80-
binary = "selenium-manager/windows/selenium-manager.exe";
81-
}
82-
else if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
83-
{
84-
binary = "selenium-manager/linux/selenium-manager";
85-
}
86-
else if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
87-
{
88-
binary = "selenium-manager/macos/selenium-manager";
89-
}
90-
else
91-
{
92-
throw new WebDriverException("Selenium Manager did not find supported operating system");
93-
}
78+
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
79+
{
80+
binary = "selenium-manager/windows/selenium-manager.exe";
81+
}
82+
else if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
83+
{
84+
binary = "selenium-manager/linux/selenium-manager";
85+
}
86+
else if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
87+
{
88+
binary = "selenium-manager/macos/selenium-manager";
89+
}
90+
else
91+
{
92+
throw new WebDriverException("Selenium Manager did not find supported operating system");
93+
}
9494
#endif
9595
}
9696

@@ -145,9 +145,9 @@ private static string RunCommand(string fileName, string arguments)
145145

146146
string output = outputBuilder.ToString().Trim();
147147

148-
if (processExitCode > 0)
148+
if (processExitCode != 0)
149149
{
150-
throw new WebDriverException($"Invalid response from process: {fileName} {arguments}\n{output}");
150+
throw new WebDriverException($"Invalid response from process (code {processExitCode}): {fileName} {arguments}\n{output}");
151151
}
152152

153153
return output.Replace("INFO\t", "");

0 commit comments

Comments
 (0)