Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat]: remove 'use client' from navigation-menu.tsx #6888

Open
2 tasks done
benwaffle opened this issue Mar 7, 2025 · 4 comments · May be fixed by #6913
Open
2 tasks done

[feat]: remove 'use client' from navigation-menu.tsx #6888

benwaffle opened this issue Mar 7, 2025 · 4 comments · May be fixed by #6913
Labels
area: request

Comments

@benwaffle
Copy link

Feature description

As far as I can tell, "use client" isn't necessary here, right? It seems to work fine.

Radix says all components are SSR-able.

Affected component/components

NavigationMenu

Additional Context

No response

Before submitting

  • I've made research efforts and searched the documentation
  • I've searched for existing issues and PRs
@Jacksonmills
Copy link
Contributor

looks like it's been removed, maybe you are still using an older version?

@benwaffle
Copy link
Author

I just ran pnpm dlx shadcn@latest add navigation-menu in a brand new app and it's still there.

@Jacksonmills
Copy link
Contributor

I'll test this today

@Jacksonmills
Copy link
Contributor

noticed it seems the v4 navigation menu still has 'use client' I can open a PR to remove

@Jacksonmills Jacksonmills linked a pull request Mar 12, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(navigation-menu v4): 6888 - Remove "use client" directive Jacksonmills/ui
2 participants
@benwaffle @Jacksonmills