Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] increase to angular 17 #2113

Merged
merged 13 commits into from
Dec 4, 2023
Merged

Conversation

phhbr
Copy link
Contributor

@phhbr phhbr commented Nov 24, 2023

Fixes #2110

Copy link

@CodeMaverickVikash CodeMaverickVikash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@phhbr
Copy link
Contributor Author

phhbr commented Dec 1, 2023

@RobbieTheWagner can you take a look when you got time?

@RobbieTheWagner
Copy link
Member

@phhbr it looks like node version needs to be updated. CI will not run.

@phhbr
Copy link
Contributor Author

phhbr commented Dec 3, 2023

Could you re-trigger the CI?

@RobbieTheWagner
Copy link
Member

@phhbr looks like we have this error now Error: Module not found: Error: Package path ./dist/zone-testing

@phhbr phhbr marked this pull request as draft December 4, 2023 12:25
@phhbr phhbr marked this pull request as ready for review December 4, 2023 12:49
@phhbr
Copy link
Contributor Author

phhbr commented Dec 4, 2023

I set-up a CI on the fork, which runs green now. Should be merge-able.

@rajpeddalachugari
Copy link

@phhbr could you please generate the build as soon as possible . our upgrade process is dependent on this 😄

@RobbieTheWagner RobbieTheWagner merged commit 54812e0 into shipshapecode:main Dec 4, 2023
This was referenced Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 17 Update
4 participants