Skip to content

Commit 12712f1

Browse files
committed
Allow eliminating the frame pointer on x86_64-apple-darwin
Quoting @alexcrichton: > the fp elim here comes from the code contents of the patch: > > ```rust > // FIXME: rust-lang#11906: Omitting frame pointers breaks retrieving the value of a parameter. > // FIXME: rust-lang#11954: mac64 unwinding may not work with fp elim > let no_fp_elim = (sess.opts.debuginfo != NoDebugInfo) || > (sess.targ_cfg.os == abi::OsMacos && > sess.targ_cfg.arch == abi::X86_64); > ``` > > > which points to rust-lang#11954 which > I believe was [incorrectly closed][] (only references i686, not > x86_64). > > This sounds vaguely familiar about how it's related to > unwinding. This also is the definition of something lost to time > which we unfortunately lost track of :(. > > [incorrectly closed]: rust-lang#11954 (comment)
1 parent f9a3086 commit 12712f1

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/librustc_target/spec/x86_64_apple_darwin.rs

-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ pub fn target() -> TargetResult {
44
let mut base = super::apple_base::opts();
55
base.cpu = "core2".to_string();
66
base.max_atomic_width = Some(128); // core2 support cmpxchg16b
7-
base.eliminate_frame_pointer = false;
87
base.pre_link_args.insert(LinkerFlavor::Gcc, vec!["-m64".to_string()]);
98
base.link_env_remove.extend(super::apple_base::macos_link_env_remove());
109
base.stack_probes = true;

0 commit comments

Comments
 (0)