Skip to content

Commit c75ba89

Browse files
committed
Remove kube_*_annotations from deny list
Since kubernetes/kube-state-metrics#2145, kube-state-metrics does not collect `kube_*_annotations` metrics by default. It's no longer necessary to add them to the metrics' deny list. Removing `kube_*_annotations` from the deny list allows us to enable scrapping of annotation metrics via the `--metric-annotations-allowlist` option. Additionally, we were missing a comma, which might have been a problem in the comma-separated list of arguments.
1 parent cb3d884 commit c75ba89

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

assets/kube-state-metrics/deployment.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ spec:
3939
- |
4040
--metric-denylist=
4141
^kube_secret_labels$,
42-
^kube_.+_annotations$
4342
^kube_customresource_.+_annotations_info$,
4443
^kube_customresource_.+_labels_info$,
4544
- --metric-labels-allowlist=pods=[*],nodes=[*],namespaces=[*],persistentvolumes=[*],persistentvolumeclaims=[*],poddisruptionbudgets=[*]

jsonnet/components/kube-state-metrics.libsonnet

-1
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,6 @@ function(params)
240240
|||
241241
--metric-denylist=
242242
^kube_secret_labels$,
243-
^kube_.+_annotations$
244243
^kube_customresource_.+_annotations_info$,
245244
^kube_customresource_.+_labels_info$,
246245
|||,

0 commit comments

Comments
 (0)