Skip to content

Session.connect_server('browser_penncnp') should return a context manager #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shippy opened this issue Sep 17, 2018 · 0 comments
Open

Session.connect_server('browser_penncnp') should return a context manager #19

shippy opened this issue Sep 17, 2018 · 0 comments

Comments

@shippy
Copy link
Contributor

shippy commented Sep 17, 2018

sibis-platform/ncanda-operations#7415 & co. almost always happen because get_selenium_results terminated halfway through, without calling sibis_session.disconnect_penncnp(). At first glance, this seems like a textbook case where a context manager could be used to prevent the error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shippy