Skip to content

Commit 4b486d2

Browse files
author
hectorj2f
committed
add missing third_party packages
Signed-off-by: hectorj2f <[email protected]>
1 parent 47721e5 commit 4b486d2

16 files changed

+77
-52
lines changed

cmd/cosign/cli/attest.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ func Attest() *cobra.Command {
7171
OIDCIssuer: o.OIDC.Issuer,
7272
OIDCClientID: o.OIDC.ClientID,
7373
OIDCClientSecret: o.OIDC.ClientSecret,
74-
OIDCRedirectURI: o.OIDC.RedirectURI,
74+
OIDCRedirectURL: o.OIDC.RedirectURL,
7575
}
7676
for _, img := range args {
7777
if err := attest.AttestCmd(cmd.Context(), ko, o.Registry, img, o.Cert, o.CertChain, o.NoUpload,

cmd/cosign/cli/fulcio/fulcio.go

+8-8
Original file line numberDiff line numberDiff line change
@@ -51,17 +51,17 @@ type realConnector struct {
5151
flow oauthflow.TokenGetter
5252
}
5353

54-
func (rf *realConnector) OIDConnect(url, clientID, secret, redirectURI string) (*oauthflow.OIDCIDToken, error) {
55-
return oauthflow.OIDConnect(url, clientID, secret, redirectURI, rf.flow)
54+
func (rf *realConnector) OIDConnect(url, clientID, secret, redirectURL string) (*oauthflow.OIDCIDToken, error) {
55+
return oauthflow.OIDConnect(url, clientID, secret, redirectURL, rf.flow)
5656
}
5757

58-
func getCertForOauthID(priv *ecdsa.PrivateKey, fc api.Client, connector oidcConnector, oidcIssuer, oidcClientID, oidcClientSecret, oidcRedirectURI string) (*api.CertificateResponse, error) {
58+
func getCertForOauthID(priv *ecdsa.PrivateKey, fc api.Client, connector oidcConnector, oidcIssuer, oidcClientID, oidcClientSecret, oidcRedirectURL string) (*api.CertificateResponse, error) {
5959
pubBytes, err := x509.MarshalPKIXPublicKey(&priv.PublicKey)
6060
if err != nil {
6161
return nil, err
6262
}
6363

64-
tok, err := connector.OIDConnect(oidcIssuer, oidcClientID, oidcClientSecret, oidcRedirectURI)
64+
tok, err := connector.OIDConnect(oidcIssuer, oidcClientID, oidcClientSecret, oidcRedirectURL)
6565
if err != nil {
6666
return nil, err
6767
}
@@ -85,7 +85,7 @@ func getCertForOauthID(priv *ecdsa.PrivateKey, fc api.Client, connector oidcConn
8585
}
8686

8787
// GetCert returns the PEM-encoded signature of the OIDC identity returned as part of an interactive oauth2 flow plus the PEM-encoded cert chain.
88-
func GetCert(ctx context.Context, priv *ecdsa.PrivateKey, idToken, flow, oidcIssuer, oidcClientID, oidcClientSecret, oidcRedirectURI string, fClient api.Client) (*api.CertificateResponse, error) {
88+
func GetCert(ctx context.Context, priv *ecdsa.PrivateKey, idToken, flow, oidcIssuer, oidcClientID, oidcClientSecret, oidcRedirectURL string, fClient api.Client) (*api.CertificateResponse, error) {
8989
c := &realConnector{}
9090
switch flow {
9191
case FlowDevice:
@@ -99,7 +99,7 @@ func GetCert(ctx context.Context, priv *ecdsa.PrivateKey, idToken, flow, oidcIss
9999
return nil, fmt.Errorf("unsupported oauth flow: %s", flow)
100100
}
101101

102-
return getCertForOauthID(priv, fClient, c, oidcIssuer, oidcClientID, oidcClientSecret, oidcRedirectURI)
102+
return getCertForOauthID(priv, fClient, c, oidcIssuer, oidcClientID, oidcClientSecret, oidcRedirectURL)
103103
}
104104

105105
type Signer struct {
@@ -110,7 +110,7 @@ type Signer struct {
110110
*signature.ECDSASignerVerifier
111111
}
112112

113-
func NewSigner(ctx context.Context, idToken, oidcIssuer, oidcClientID, oidcClientSecret, oidcRedirectURI string, fClient api.Client) (*Signer, error) {
113+
func NewSigner(ctx context.Context, idToken, oidcIssuer, oidcClientID, oidcClientSecret, oidcRedirectURL string, fClient api.Client) (*Signer, error) {
114114
priv, err := cosign.GeneratePrivateKey()
115115
if err != nil {
116116
return nil, errors.Wrap(err, "generating cert")
@@ -131,7 +131,7 @@ func NewSigner(ctx context.Context, idToken, oidcIssuer, oidcClientID, oidcClien
131131
default:
132132
flow = FlowNormal
133133
}
134-
Resp, err := GetCert(ctx, priv, idToken, flow, oidcIssuer, oidcClientID, oidcClientSecret, oidcRedirectURI, fClient) // TODO, use the chain.
134+
Resp, err := GetCert(ctx, priv, idToken, flow, oidcIssuer, oidcClientID, oidcClientSecret, oidcRedirectURL, fClient) // TODO, use the chain.
135135
if err != nil {
136136
return nil, errors.Wrap(err, "retrieving cert")
137137
}

cmd/cosign/cli/fulcio/fulcio_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ type testFlow struct {
3636
err error
3737
}
3838

39-
func (tf *testFlow) OIDConnect(url, clientID, secret, redirectURI string) (*oauthflow.OIDCIDToken, error) {
39+
func (tf *testFlow) OIDConnect(url, clientID, secret, redirectURL string) (*oauthflow.OIDCIDToken, error) {
4040
if tf.err != nil {
4141
return nil, tf.err
4242
}

cmd/cosign/cli/fulcio/fulcioverifier/fulcioverifier.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,8 @@ func verifySCT(ctx context.Context, certPEM, rawSCT []byte) error {
110110
return verifySctErr
111111
}
112112

113-
func NewSigner(ctx context.Context, idToken, oidcIssuer, oidcClientID, oidcClientSecret, oidcRedirectURI string, fClient api.Client) (*fulcio.Signer, error) {
114-
fs, err := fulcio.NewSigner(ctx, idToken, oidcIssuer, oidcClientID, oidcClientSecret, oidcRedirectURI, fClient)
113+
func NewSigner(ctx context.Context, idToken, oidcIssuer, oidcClientID, oidcClientSecret, oidcRedirectURL string, fClient api.Client) (*fulcio.Signer, error) {
114+
fs, err := fulcio.NewSigner(ctx, idToken, oidcIssuer, oidcClientID, oidcClientSecret, oidcRedirectURL, fClient)
115115
if err != nil {
116116
return nil, err
117117
}

cmd/cosign/cli/options/oidc.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ type OIDCOptions struct {
2626
Issuer string
2727
ClientID string
2828
ClientSecret string
29-
RedirectURI string
29+
RedirectURL string
3030
}
3131

3232
var _ Interface = (*OIDCOptions)(nil)
@@ -42,6 +42,6 @@ func (o *OIDCOptions) AddFlags(cmd *cobra.Command) {
4242
cmd.Flags().StringVar(&o.ClientSecret, "oidc-client-secret", "",
4343
"[EXPERIMENTAL] OIDC client secret for application")
4444

45-
cmd.Flags().StringVar(&o.RedirectURI, "oidc-redirect-uri", "",
46-
"[EXPERIMENTAL] OIDC redirect URI")
45+
cmd.Flags().StringVar(&o.RedirectURL, "oidc-redirect-url", "",
46+
"[EXPERIMENTAL] OIDC redirect URL (Optional). The default oidc-redirect-url is 'http://localhost:0/auth/callback'.")
4747
}

cmd/cosign/cli/policy_init.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ func signPolicy() *cobra.Command {
183183
OIDCIssuer: o.OIDC.Issuer,
184184
OIDCClientID: o.OIDC.ClientID,
185185
OIDCClientSecret: o.OIDC.ClientSecret,
186-
OIDCRedirectURI: o.OIDC.RedirectURI,
186+
OIDCRedirectURL: o.OIDC.RedirectURL,
187187
})
188188
if err != nil {
189189
return err

cmd/cosign/cli/sign.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ func Sign() *cobra.Command {
8787
OIDCIssuer: o.OIDC.Issuer,
8888
OIDCClientID: o.OIDC.ClientID,
8989
OIDCClientSecret: o.OIDC.ClientSecret,
90-
OIDCRedirectURI: o.OIDC.RedirectURI,
90+
OIDCRedirectURL: o.OIDC.RedirectURL,
9191
}
9292
annotationsMap, err := o.AnnotationsMap()
9393
if err != nil {

cmd/cosign/cli/sign/sign.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -438,11 +438,11 @@ func keylessSigner(ctx context.Context, ko KeyOpts) (*SignerVerifier, error) {
438438
var k *fulcio.Signer
439439

440440
if ko.InsecureSkipFulcioVerify {
441-
if k, err = fulcio.NewSigner(ctx, tok, ko.OIDCIssuer, ko.OIDCClientID, ko.OIDCClientSecret, ko.OIDCRedirectURI, fClient); err != nil {
441+
if k, err = fulcio.NewSigner(ctx, tok, ko.OIDCIssuer, ko.OIDCClientID, ko.OIDCClientSecret, ko.OIDCRedirectURL, fClient); err != nil {
442442
return nil, errors.Wrap(err, "getting key from Fulcio")
443443
}
444444
} else {
445-
if k, err = fulcioverifier.NewSigner(ctx, tok, ko.OIDCIssuer, ko.OIDCClientID, ko.OIDCClientSecret, ko.OIDCRedirectURI, fClient); err != nil {
445+
if k, err = fulcioverifier.NewSigner(ctx, tok, ko.OIDCIssuer, ko.OIDCClientID, ko.OIDCClientSecret, ko.OIDCRedirectURL, fClient); err != nil {
446446
return nil, errors.Wrap(err, "getting key from Fulcio")
447447
}
448448
}

cmd/cosign/cli/sign/sign_blob.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ type KeyOpts struct {
4545
OIDCIssuer string
4646
OIDCClientID string
4747
OIDCClientSecret string
48-
OIDCRedirectURI string
48+
OIDCRedirectURL string
4949
BundlePath string
5050

5151
// Modeled after InsecureSkipVerify in tls.Config, this disables

cmd/cosign/cli/signblob.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ func SignBlob() *cobra.Command {
7676
OIDCIssuer: o.OIDC.Issuer,
7777
OIDCClientID: o.OIDC.ClientID,
7878
OIDCClientSecret: o.OIDC.ClientSecret,
79-
OIDCRedirectURI: o.OIDC.RedirectURI,
79+
OIDCRedirectURL: o.OIDC.RedirectURL,
8080
BundlePath: o.BundlePath,
8181
}
8282
for _, blob := range args {

doc/cosign_attest.md

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

doc/cosign_policy_sign.md

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

doc/cosign_sign-blob.md

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

doc/cosign_sign.md

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

go.mod

+3-8
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ require (
3838
github.com/secure-systems-lab/go-securesystemslib v0.3.1
3939
github.com/sigstore/fulcio v0.1.2-0.20220114150912-86a2036f9bc7
4040
github.com/sigstore/rekor v0.4.1-0.20220114213500-23f583409af3
41-
github.com/sigstore/sigstore v1.2.1-0.20220328200116-ef48ee800626
41+
github.com/sigstore/sigstore v1.2.1-0.20220330193110-d7475aecf1db
4242
github.com/spf13/cobra v1.4.0
4343
github.com/spf13/viper v1.10.1
4444
github.com/spiffe/go-spiffe/v2 v2.0.0
@@ -113,7 +113,7 @@ require (
113113
cloud.google.com/go/kms v1.4.0 // indirect
114114
contrib.go.opencensus.io/exporter/ocagent v0.7.1-0.20200907061046-05415f1de66d // indirect
115115
contrib.go.opencensus.io/exporter/prometheus v0.4.0 // indirect
116-
github.com/Azure/azure-sdk-for-go v62.3.0+incompatible // indirect
116+
github.com/Azure/azure-sdk-for-go v63.0.0+incompatible // indirect
117117
github.com/Azure/go-autorest v14.2.0+incompatible // indirect
118118
github.com/Azure/go-autorest/autorest v0.11.24 // indirect
119119
github.com/Azure/go-autorest/autorest/adal v0.9.18 // indirect
@@ -131,7 +131,7 @@ require (
131131
github.com/PuerkitoBio/urlesc v0.0.0-20170810143723-de5bf2ad4578 // indirect
132132
github.com/ReneKroon/ttlcache/v2 v2.11.0 // indirect
133133
github.com/asaskevich/govalidator v0.0.0-20210307081110-f21760c49a8d // indirect
134-
github.com/aws/aws-sdk-go v1.43.27 // indirect
134+
github.com/aws/aws-sdk-go v1.43.28 // indirect
135135
github.com/aws/aws-sdk-go-v2 v1.14.0 // indirect
136136
github.com/aws/aws-sdk-go-v2/config v1.14.0 // indirect
137137
github.com/aws/aws-sdk-go-v2/credentials v1.9.0 // indirect
@@ -219,13 +219,11 @@ require (
219219
github.com/jedisct1/go-minisign v0.0.0-20210703085342-c1f07ee84431 // indirect
220220
github.com/jhump/protoreflect v1.9.0 // indirect
221221
github.com/jmespath/go-jmespath v0.4.0 // indirect
222-
github.com/jmhodges/clock v0.0.0-20160418191101-880ee4c33548 // indirect
223222
github.com/jonboulle/clockwork v0.2.2 // indirect
224223
github.com/josharian/intern v1.0.0 // indirect
225224
github.com/json-iterator/go v1.1.12 // indirect
226225
github.com/klauspost/compress v1.14.2 // indirect
227226
github.com/leodido/go-urn v1.2.1 // indirect
228-
github.com/letsencrypt/boulder v0.0.0-20220322173223-dd8be8d7b02c // indirect
229227
github.com/magiconair/properties v1.8.5 // indirect
230228
github.com/mailru/easyjson v0.7.7 // indirect
231229
github.com/mattn/go-colorable v0.1.12 // indirect
@@ -264,7 +262,6 @@ require (
264262
github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7 // indirect
265263
github.com/tent/canonical-json-go v0.0.0-20130607151641-96e4ba3a7613 // indirect
266264
github.com/thales-e-security/pool v0.0.2 // indirect
267-
github.com/titanous/rocacheck v0.0.0-20171023193734-afe73141d399 // indirect
268265
github.com/tmc/grpc-websocket-proxy v0.0.0-20201229170055-e5319fda7802 // indirect
269266
github.com/vbatts/tar-split v0.11.2 // indirect
270267
github.com/xeipuuv/gojsonpointer v0.0.0-20190905194746-02993c407bfb // indirect
@@ -315,5 +312,3 @@ require (
315312
sigs.k8s.io/json v0.0.0-20211208200746-9f7c6b3444d2 // indirect
316313
sigs.k8s.io/structured-merge-diff/v4 v4.2.1 // indirect
317314
)
318-
319-
replace github.com/sigstore/sigstore => github.com/hectorj2f/sigstore v1.1.1-0.20220328195805-4ade568cebda

0 commit comments

Comments
 (0)