Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Use ngx as prefix instead of sc #7

Open
the-ult opened this issue Jul 2, 2024 · 2 comments
Open

[Suggestion] Use ngx as prefix instead of sc #7

the-ult opened this issue Jul 2, 2024 · 2 comments

Comments

@the-ult
Copy link
Collaborator

the-ult commented Jul 2, 2024

Hey Brecht,

I know sc is the prefix of Simplified Courses, but I think the library will be used more if the prefix is a bit more global/less tied to Simplified Courses.

Also it would seem more logic, since the library name is ngx-vest-forms

So suggestions for a new prefix:

  • ngx
  • ngv
  • nvf

I like ngx the most 😇

I'm willing to create a PR (and might try to provide a schematic as well, since it is a breaking change)

@simplifiedcourses
Copy link
Owner

Hi There!

I'm not against changing the suffix, after all it's about helping people.
some thoughts:

  • I believe the suffix should be unique, I think that's the idea of a suffix. Would ngx be unique enough? since it is the standard for angular libraries?
  • This will introduce a breaking change so I'd like to combine that with other breaking changes
  • The lib is still not widely used, so maybe this is the time.

@the-ult
Copy link
Collaborator Author

the-ult commented Jul 2, 2024

The lib is still not widely used, so maybe this is the time.

Yeah, was thinking the same thing.

I believe the suffix should be unique, I think that's the idea of a suffix. Would ngx be unique enough? since it is the standard for angular libraries?

Don't know if ngx is unique enough. But on the other hand. You probably won't have multiple libraries installed with the ngx prefix, that have the same kind of form directives/components.. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants