Error after error in nodejs 23.4.0: [TypeError: (intermediate value).get(...).replace is not a function]

[dincerpece]

Description

After migrating from nodejs 23.3.0 to 23.4.0, I encountered an error in my code. Your fileTypeFromBuffer function gives an error and does not return a value, and naturally my code stops working there. It does not pass to "console.log(fileType)" at all, it gives an error without even getting an empty value, and the fileTypeFromBuffer function stops working! While it worked fine in Node.js 23.3.0, this problem occurred in 23.4.0.

Existing Issue Check

• I have searched the existing issues and could not find any related to my problem.

ESM (ECMAScript Module) Requirement Acknowledgment

• My project is an ESM project and my package.json contains the following entry: "type": "module".

File-Type Scope Acknowledgment

• I understand that file-type detects binary file types and not text or other formats.

[Borewit]

I could not reproduce your issue @dincerpece:

import { readFileSync } from 'node:fs';
import { fileTypeFromBuffer } from 'file-type';
import { versions } from 'process';

console.log(`Node.js version: ${versions.node}`);

const buffer = readFileSync('sample-gif-files-sample_640x426.gif');
const result = await fileTypeFromBuffer(buffer);
console.log(JSON.stringify(result));

Outputs:

Node.js version: 23.4.0
{"ext":"gif","mime":"image/gif"}

[Borewit]

I managed to reproduce the issue, use the previous code sample, parsing: fixture.cr3.

That outputs:

TypeError: (intermediate value).get(...).replace is not a function
    at FileTypeParser.parse (file:///C:/Users/Borewit/IdeaProjects/file-type/core.js:613:77)

which refers to:

file-type/core.js

Line 613 in e99257d

const brandMajor = new Token.StringType(4, 'latin1').get(this.buffer, 8).replace('\0', ' ').trim();

[Borewit]

Looks like a bug in Node.js 23.4.0, in the TextDecoder.decode(): nodejs/node#56219

const encoding = 'latin1';
const buffer = Buffer.from('Hello!', encoding); // Initializes: <Buffer 48 65 6c 6c 6f 21>
const textDecoder = new TextDecoder(encoding);
const decodedString = textDecoder.decode(buffer);
const returnType = typeof decodedString;
if (returnType === 'string') {
    console.log('Fine, we got a string, as expected');
} else {
    console.error('This is odd, we received an ' + returnType);
}

Outputs in 23.4.0:

This is odd, we received an object