Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shebang length exceeded in pip executable #30

Closed
rmb938 opened this issue Oct 24, 2016 · 3 comments
Closed

Shebang length exceeded in pip executable #30

rmb938 opened this issue Oct 24, 2016 · 3 comments

Comments

@rmb938
Copy link
Contributor

rmb938 commented Oct 24, 2016

See the following issue on pip: pypa/pip#1773

The accepted solution seems to be running the following:

/some/path/to/python -m pip

I would make a PR but I am not sure on how you want to go about supporting that.

@sjkingo
Copy link
Owner

sjkingo commented Oct 25, 2016

An interesting problem that I'd never considered. Have you run into this personally?

If we could have some tests that show it breaks with paths longer than BINPRM_BUF_SIZE, and changing the invocation of pip to run as a module doesn't break anything, that should be OK.

Could we just change _pip_rpath() to instead search for the python executable and return that + ['-m', 'pip']?

@rmb938
Copy link
Contributor Author

rmb938 commented Oct 25, 2016

Yea, I am running into it while testing an application in jenkins that just happens to have really long path names.

I can get those changes in and a pull request made.

@sjkingo
Copy link
Owner

sjkingo commented Oct 26, 2016

Awesome, thank you Ryan. I have released version 2.1.13 that includes this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants