Fixes #621: Font::uchr: allow int|float for $code parameter (#623)

* Font::uchr: extends parameter $code to int|float

* Add files via upload

* fixed int|float so code runs on PHP 7.x

* add test case

* fixed coding style issue in Font.php

* added note

* Update Font.php

Author: k00ni

samples/bugs/Issue621.pdf

@@ -134,9 +134,16 @@ public function translateChar(string $char, bool $use_default = true)
 
     /**
      * Convert unicode character code to "utf-8" encoded string.
+     *
+     * @param int|float $code Unicode character code. Will be casted to int internally!
      */
-    public static function uchr(int $code): string
+    public static function uchr($code): string
     {
+        // note:
+        // $code was typed as int before, but changed in https://github.com/smalot/pdfparser/pull/623
+        // because in some cases uchr was called with a float instead of an integer.
+        $code = (int) $code;
+
         if (!isset(self::$uchrCache[$code])) {
             // html_entity_decode() will not work with UTF-16 or UTF-32 char entities,
             // therefore, we use mb_convert_encoding() instead

src/Smalot/PdfParser/Font.php

@@ -294,6 +294,18 @@ public function testIssue557(): void
         );
     }
 
+    /**
+     * Tests if an integer overflow triggers a TypeError in Font::uchr.
+     *
+     * @see https://github.com/smalot/pdfparser/issues/621
+     */
+    public function testIssue621(): void
+    {
+        $document = $this->fixture->parseFile($this->rootDir.'/samples/bugs/Issue621.pdf');
+
+        $this->assertStringContainsString('What is a biological product?', $document->getText());
+    }
+
     /**
      * Tests behavior when changing default font space limit (-50).
      *