Skip to content

Stop passing String and Byte[Array] of records around #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexanderdean opened this issue May 30, 2015 · 0 comments
Closed

Stop passing String and Byte[Array] of records around #32

alexanderdean opened this issue May 30, 2015 · 0 comments
Assignees
Milestone

Comments

@alexanderdean
Copy link
Member

We pass around both the String and Byte[Array] versions of each record to make failure logging easier, but this doubles the amount of memory we need in the heap.

Instead, we can just pass the Byte[Array] around and reverse out the String for any failure rows. Failures will be rare anyway given we are not doing any record-level processing.

@alexanderdean alexanderdean added this to the Version 0.3.0 milestone May 30, 2015
@alexanderdean alexanderdean changed the title Don't pass String and Byte[Array] of records around Stop passing String and Byte[Array] of records around Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants