Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disconnected sockets are never removed from memory #4028

Closed
Novivy opened this issue Jul 21, 2021 · 1 comment
Closed

Disconnected sockets are never removed from memory #4028

Novivy opened this issue Jul 21, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@Novivy
Copy link

Novivy commented Jul 21, 2021

Describe the bug
When a socket is disconnected, the server doesn't remove it from the memory.

To Reproduce

See #2427 (comment)

Expected behavior
Disconnected socket shouldn't be kept in memory forever

Platform:
v4.1.3

Additional context
@Novivy Novivy added the bug Something isn't working label Jul 21, 2021
@BlackBacker BlackBacker mentioned this issue Aug 30, 2021
Closed
@darrachequesne
Copy link
Member

For future readers:

I was not able to reproduce the issue.

Node version: v16.13.1
Socket.IO version: v4.4.1

I used the scripts from https://github.com/socketio/socket.io-benchmarks, here is the graph with 10 000 clients:

Screenshot from 2022-03-31 23-36-43

Please reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darrachequesne @Novivy