Skip to content

Commit 47d61c5

Browse files
Add upper bounds and fix hlint issue
Change-Id: Ie6d1e8827872b53127528a19e83441ef19b457d0
1 parent daa44c4 commit 47d61c5

File tree

4 files changed

+25
-19
lines changed

4 files changed

+25
-19
lines changed

.zuul.yaml

+6-5
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
11
- project:
22
check: &jobs
33
jobs:
4-
- cabal-test:
4+
- run-test-command:
55
vars:
6-
ghc_version: 8.8
7-
cabal_install_args: "--lib"
6+
test_command:
7+
- cabal build -O0 --enable-tests
8+
- cabal test -O0 --test-show-details=direct
89
nodeset:
910
nodes:
1011
- name: container
11-
label: zuul-worker-haskell
12+
label: zuul-worker-haskell-ghc9
1213
- hlint:
1314
nodeset:
1415
nodes:
1516
- name: container
16-
label: zuul-worker-haskell
17+
label: zuul-worker-haskell-ghc9
1718
gate: *jobs

CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Changelog
22

3+
## 0.1.6.1
4+
5+
- Apply hlint suggestion
6+
- Add version bounds to the build-depends
7+
38
## 0.1.6.0
49

510
- Add a nix flake

gerrit.cabal

+13-13
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
cabal-version: 2.4
22
name: gerrit
3-
version: 0.1.6.0
3+
version: 0.1.6.1
44
synopsis: A gerrit client library
55
description:
66
Gerrit is a client library to interface with https://www.gerritcodereview.com/
@@ -26,10 +26,10 @@ source-repository head
2626
location: https://github.com/softwarefactory-project/gerrit-haskell.git
2727

2828
common common-options
29-
build-depends: base >= 4.11.0.0
30-
, aeson >= 1.0.0.0
31-
, bytestring
32-
, time >= 1.9.3
29+
build-depends: base >= 4.11 && < 5
30+
, aeson >= 2.0 && < 2.3
31+
, bytestring >= 0.10 && < 0.13
32+
, time >= 1 && < 2
3333
ghc-options: -Wall
3434
-Wcompat
3535
-Widentities
@@ -48,11 +48,11 @@ common common-options
4848

4949
library
5050
import: common-options
51-
build-depends: containers >= 0.5.8.0
52-
, http-client >= 0.5.0
53-
, http-client-openssl >= 0.3.0
54-
, text >= 0.11.1.0
55-
, aeson-casing >= 0.2.0.0
51+
build-depends: containers >= 0.5.8.0 && < 0.8
52+
, http-client >= 0.5.0 && < 0.8
53+
, http-client-openssl >= 0.3.0 && < 1
54+
, text >= 0.11 && < 3
55+
, aeson-casing >= 0.2.0.0 && < 0.4
5656

5757
hs-source-dirs: src
5858
exposed-modules: Gerrit
@@ -68,10 +68,10 @@ test-suite gerrit-test
6868
type: exitcode-stdio-1.0
6969
hs-source-dirs: test
7070
main-is: Spec.hs
71-
build-depends: directory
71+
build-depends: directory >= 1.0 && < 2
7272
, gerrit
73-
, tasty >= 0.11.2
74-
, tasty-hunit >= 0.10
73+
, tasty >= 0.11.2 && < 2
74+
, tasty-hunit >= 0.10 && < 2
7575
ghc-options: -threaded
7676
-rtsopts
7777
-with-rtsopts=-N

src/Gerrit/Data/Change.hs

+1-1
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ instance FromJSON GerritTime where
196196
parseJSON = withText "UTCTimePlus" (parse . T.unpack)
197197
where
198198
format = "%F %T.000000000"
199-
tryParse f s = parseTimeM False defaultTimeLocale f s
199+
tryParse = parseTimeM False defaultTimeLocale
200200
parse s = GerritTime <$> tryParse format s
201201

202202
data GerritChangeMessage = GerritChangeMessage

0 commit comments

Comments
 (0)