Skip to content

Commit dba4f95

Browse files
authored
Rename contest leaderboard to score leaderboard (#1064)
* Rename contestLeaderboard to scoreLeaderboard In preparation of new feature which shows contest leaderboard based on votes * Rename contestLeaderboard to scoreLeaderboard for test
1 parent ace47cd commit dba4f95

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

lib/cadet_web/helpers/assessments_helpers.ex

+1-1
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ defmodule CadetWeb.AssessmentsHelpers do
180180
solutionTemplate: "template",
181181
contestEntries:
182182
&Enum.map(&1[:contest_entries], fn entry -> build_contest_entry(entry) end),
183-
contestLeaderboard:
183+
scoreLeaderboard:
184184
&Enum.map(&1[:contest_leaderboard], fn entry ->
185185
build_contest_leaderboard_entry(entry)
186186
end)

test/cadet_web/admin_controllers/admin_grading_controller_test.exs

+2-2
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ defmodule CadetWeb.AdminGradingControllerTest do
372372
"autogradingResults" => &1.autograding_results,
373373
"answer" => nil,
374374
"contestEntries" => [],
375-
"contestLeaderboard" => []
375+
"scoreLeaderboard" => []
376376
},
377377
"grade" => %{
378378
"xp" => &1.xp,
@@ -1019,7 +1019,7 @@ defmodule CadetWeb.AdminGradingControllerTest do
10191019
"autogradingResults" => &1.autograding_results,
10201020
"answer" => nil,
10211021
"contestEntries" => [],
1022-
"contestLeaderboard" => []
1022+
"scoreLeaderboard" => []
10231023
},
10241024
"grade" => %{
10251025
"xp" => &1.xp,

test/cadet_web/controllers/assessments_controller_test.exs

+4-4
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ defmodule CadetWeb.AssessmentsControllerTest do
445445
|> Enum.zip(contests_entries)
446446
|> Enum.map(fn {question, contest_entries} ->
447447
question = Map.put(question, "contestEntries", contest_entries)
448-
Map.put(question, "contestLeaderboard", [])
448+
Map.put(question, "scoreLeaderboard", [])
449449
end)
450450

451451
expected_questions =
@@ -540,7 +540,7 @@ defmodule CadetWeb.AssessmentsControllerTest do
540540
|> json_response(200)
541541
|> Map.get("questions", [])
542542
|> Enum.find(&(&1["id"] == voting_question.id))
543-
|> Map.get("contestLeaderboard")
543+
|> Map.get("scoreLeaderboard")
544544

545545
assert resp_leaderboard == expected_leaderboard
546546
end
@@ -612,7 +612,7 @@ defmodule CadetWeb.AssessmentsControllerTest do
612612
|> json_response(200)
613613
|> Map.get("questions", [])
614614
|> Enum.find(&(&1["id"] == voting_question.id))
615-
|> Map.get("contestLeaderboard")
615+
|> Map.get("scoreLeaderboard")
616616

617617
assert resp_leaderboard == expected_leaderboard
618618
end
@@ -672,7 +672,7 @@ defmodule CadetWeb.AssessmentsControllerTest do
672672
|> json_response(200)
673673
|> Map.get("questions", [])
674674
|> Enum.find(&(&1["id"] == voting_question.id))
675-
|> Map.get("contestLeaderboard")
675+
|> Map.get("scoreLeaderboard")
676676

677677
assert resp_leaderboard == expected_leaderboard
678678
end

0 commit comments

Comments
 (0)