Skip to content

Reverse the MethodToolCallback's ToolContext validation logic #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tzolov opened this issue Feb 27, 2025 · 0 comments · Fixed by #2338
Closed

Reverse the MethodToolCallback's ToolContext validation logic #2337

tzolov opened this issue Feb 27, 2025 · 0 comments · Fixed by #2338
Assignees
Milestone

Comments

@tzolov
Copy link
Contributor

tzolov commented Feb 27, 2025

Change the validation logic in MethodToolCallback to check if a ToolContext argument is defined by the method but not provided in the request.
This would ensure that methods that expect a ToolContext parameter receive one.

Current logic is checking if a ToolContext is provided but not supported by the method (e.g. the reverse)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant