-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Unable to connect db in IE 11 browser #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, I have the same issue when testing my site on IE 11. Is there a workaround, solution available? |
Hi, can this also work on IE? |
See twbs/bootstrap#21476 and https://stackoverflow.com/q/6771258 for a thorough overview. From the looks of it, this tag isn't needed for IE 10+, and IE 10 is the oldest version of IE that the dependencies of the viewer interface support as of writing (per https://github.com/farbelous/bootstrap-colorpicker/issues/271). So there's no need to include this tag. Also for posterity here's a list of all of the IE version support for the viewer interface's current dependencies (I was going to include this in a comment in the viewer interface that justified keeping the tag in, but then I realized that this tag wasn't even needed for IE 10 so I scrapped the comment) -- d3 v4: IE9+ (https://github.com/d3/d3/wiki#supported-environments) Cytoscape.js: IE9+ [supports canvas and most of ECMAScript 5] (http://js.cytoscape.org/#introduction/factsheet) jQuery: IE9+ (https://jquery.com/browser-support/) bootstrap 3: IE 8-11 (https://getbootstrap.com/docs/3.3/getting-started/#support) bootstrap colorpicker: IE >= 10 (https://github.com/farbelous/bootstrap-colorpicker/issues/271) Couldn't find much data on sql.js browser support aside from that old browsers probably aren't a good idea with it, so using IE in general with sql.js is probably not feasible. (See: https://github.com/kripken/sql.js/issues/238, https://github.com/kripken/sql.js/issues/239)
sad to know it's not feasible on IE. |
Would this work with wasm2js? |
works adding -s LEGACY_VM_SUPPORT=1 to dist/sql-asm-debug.js |
@aaaristo Awesome, I built the diff --git a/Makefile b/Makefile
index 14e0e71..17efa3d 100644
--- a/Makefile
+++ b/Makefile
@@ -39,6 +39,8 @@ EMFLAGS = \
EMFLAGS_ASM = \
-s WASM=0
+ -s LEGACY_VM_SUPPORT=1
+ -s ALLOW_MEMORY_GROWTH=1
EMFLAGS_ASM_MEMORY_GROWTH = \
-s WASM=0 \ |
can we simplify the distribution by merging i think the only reason for |
Yes, I agree.
We can merge that and remove asm-memory-growth. |
Hello,
I'm getting console error in IE 11 browser. please find the attached screenshot.
Below console error showing in sql.js file
abort("Assertion failed: this is a legacy browser, build with LEGACY_VM_SUPPORT") at Error: 0
at jsStackTrace (http://127.0.0.1:8081/js/sql.js:3:13747)
at stackTrace (http://127.0.0.1:8081/js/sql.js:3:13882)
at abort (http://127.0.0.1:8081/js/sql.js:20:8436)
at assert (http://127.0.0.1:8081/js/sql.js:3:6512)
at Anonymous function (http://127.0.0.1:8081/js/sql.js:3:17850)
at Global code (http://127.0.0.1:8081/js/sql.js:2:1)
If this abort() is unexpected, build with -s ASSERTIONS=1 which can give more information.
The text was updated successfully, but these errors were encountered: