Skip to content

Commit 7b81cb2

Browse files
chore!: add node engine support from 14.x+ (twilio#204)
Co-authored-by: shrutiburman <[email protected]>
1 parent 105be81 commit 7b81cb2

File tree

6 files changed

+10
-8
lines changed

6 files changed

+10
-8
lines changed

.github/workflows/cli-core-audit.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
strategy:
1111
fail-fast: false
1212
matrix:
13-
node-version: [16.x, 14.x, 12.x, 10.x]
13+
node-version: [18.x, 16.x, 14.x]
1414
steps:
1515
- name: Checkout cli repo
1616
uses: actions/checkout@v2

.github/workflows/cli-core-test.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
strategy:
1111
fail-fast: false
1212
matrix:
13-
node-version: [16.x, 14.x, 12.x, 10.x]
13+
node-version: [18.x, 16.x, 14.x]
1414
steps:
1515
- name: Checkout cli core repo
1616
uses: actions/checkout@v2

.github/workflows/release.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,15 @@ jobs:
4444
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
4545
aws-session-token: ${{ secrets.AWS_SESSION_TOKEN }}
4646
aws-region: us-east-1
47-
47+
4848
cli-token-validation:
4949
needs: [ cli-core-token-validation ]
5050
runs-on: ubuntu-latest
5151
steps:
5252
- name: Checkout cli-core repo
5353
uses: actions/checkout@v2
5454
- name: Execute py script to validate twilio-cli tokens
55-
id: cli_token
55+
id: cli_token
5656
run: |
5757
output=$(python3 .github/scripts/validate_cli_tokens.py)
5858
echo "::set-output name=tokenStatus::$output"
@@ -87,7 +87,7 @@ jobs:
8787
runs-on: ubuntu-latest
8888
strategy:
8989
matrix:
90-
node-version: [10.x, 12.x, 14.x, 16.x]
90+
node-version: [14.x, 16.x, 18.x]
9191
steps:
9292
- name: Checkout cli-core repo
9393
uses: actions/checkout@v2

Dockerfile

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
FROM node:8-jessie
1+
FROM node:14.18.1
22
RUN apt-get update && apt-get install -y libsecret-1-dev
33

44
RUN mkdir /cli-core
55
WORKDIR /cli-core
66
COPY . .
7-
RUN npm install ./cli-test
87
RUN npm install
98
CMD ["npm", "test"]

README.md

+3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44

55
This module contains core functionality for the twilio-cli.
66

7+
## Requirements
8+
Currently, Node 14+ is supported. We support the [LTS versions](https://nodejs.org/en/about/releases) of Node.
9+
710
## Base commands
811

912
### BaseCommand

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,6 @@
6868
"keytar": "^7.6.0"
6969
},
7070
"engines": {
71-
"node": ">=10.12.0"
71+
"node": ">=14.0.0"
7272
}
7373
}

0 commit comments

Comments
 (0)