Merge pull request YahooArchive#46 from jedireza/jscs-lint

More code style consistency

Author: jedireza

.jscsrc

@@ -0,0 +1,62 @@
+{
+    "excludeFiles": [
+        "./node_modules/**",
+        "./chat/build/**",
+        "./routing/build/**"
+    ],
+    "disallowMixedSpacesAndTabs": true,
+    "disallowNewlineBeforeBlockStatements": true,
+    "disallowPaddingNewlinesInBlocks": true,
+    "disallowSpaceAfterObjectKeys": true,
+    "disallowTrailingComma": true,
+
+    "maximumLineLength": {
+        "value": 120,
+        "allowComments": true,
+        "allowUrlComments": true,
+        "allowRegex": true
+    },
+
+    "requireBlocksOnNewline": true,
+    "requireCamelCaseOrUpperCaseIdentifiers": "ignoreProperties",
+    "requireCapitalizedConstructors": true,
+    "requireCommaBeforeLineBreak": true,
+    "requireSpaceAfterKeywords":  [
+        "if",
+        "else",
+        "for",
+        "while",
+        "do",
+        "switch",
+        "return",
+        "try",
+        "catch"
+    ],
+    "requireSpaceAfterLineComment": true,
+    "requireSpaceBeforeBlockStatements": true,
+    "requireSpacesInConditionalExpression": {
+        "afterTest": true,
+        "beforeConsequent": true,
+        "afterConsequent": true,
+        "beforeAlternate": true
+    },
+    "requireSpacesInAnonymousFunctionExpression": {
+        "beforeOpeningCurlyBrace": true
+    },
+    "requireSpacesInFunctionExpression": {
+        "beforeOpeningCurlyBrace": true
+    },
+    "requireSpacesInNamedFunctionExpression": {
+        "beforeOpeningCurlyBrace": true
+    },
+
+    "safeContextKeyword": ["self"],
+
+    "validateIndentation": 4,
+    "validateJSDoc": {
+        "checkParamNames": true,
+        "checkRedundantParams": true,
+        "requireParamTypes": true
+    },
+    "validateQuoteMarks": { "mark": "'", "escape": true }
+}

chat/actions/createMessage.js

@@ -3,9 +3,8 @@
  * Copyrights licensed under the New BSD License. See the accompanying LICENSE file for terms.
  */
 'use strict';
-
-var debug = require('debug')('Example:createMessageAction'),
-    ThreadStore = require('../stores/ThreadStore');
+var debug = require('debug')('Example:createMessageAction');
+var ThreadStore = require('../stores/ThreadStore');
 
 module.exports = function (context, payload, done) {
     var threadStore = context.getStore(ThreadStore);

chat/actions/openThread.js

@@ -3,9 +3,8 @@
  * Copyrights licensed under the New BSD License. See the accompanying LICENSE file for terms.
  */
 'use strict';
-
-var debug = require('debug')('Example:openThreadAction'),
-    ThreadStore = require('../stores/ThreadStore');
+var debug = require('debug')('Example:openThreadAction');
+var ThreadStore = require('../stores/ThreadStore');
 
 module.exports = function (context, payload, done) {
     debug('dispatching OPEN_THREAD', payload);

chat/actions/showChat.js

@@ -3,10 +3,9 @@
  * Copyrights licensed under the New BSD License. See the accompanying LICENSE file for terms.
  */
 'use strict';
-
-var debug = require('debug')('Example:showChatAction'),
-    ThreadStore = require('../stores/ThreadStore'),
-    openThread = require('./openThread');
+var debug = require('debug')('Example:showChatAction');
+var ThreadStore = require('../stores/ThreadStore');
+var openThread = require('./openThread');
 
 module.exports = function (context, payload, done) {
     context.dispatch('SHOW_CHAT_START');

chat/components/ChatApp.jsx

@@ -12,10 +12,8 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
- *
- * @jsx React.DOM
  */
-
+'use strict';
 var MessageSection = require('./MessageSection.jsx');
 var React = require('react');
 var ThreadSection = require('./ThreadSection.jsx');

chat/components/Head.jsx

@@ -1,5 +1,8 @@
+/**
+ * Copyright 2014, Yahoo! Inc.
+ * Copyrights licensed under the New BSD License. See the accompanying LICENSE file for terms.
+ */
 'use strict';
-
 var React = require('react');
 
 /**

chat/components/MessageComposer.jsx

@@ -12,10 +12,8 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
- *
- * @jsx React.DOM
  */
-
+'use strict';
 var React = require('react');
 var createMessage = require('../actions/createMessage');
 

chat/components/MessageListItem.jsx

@@ -12,10 +12,8 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
- *
- * @jsx React.DOM
  */
-
+'use strict';
 var React = require('react');
 
 var ReactPropTypes = React.PropTypes;

chat/components/MessageSection.jsx

@@ -12,10 +12,8 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
- *
- * @jsx React.DOM
  */
-
+'use strict';
 var MessageComposer = require('./MessageComposer.jsx');
 var MessageListItem = require('./MessageListItem.jsx');
 var MessageStore = require('../stores/MessageStore');

chat/components/ThreadListItem.jsx

@@ -12,10 +12,8 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
- *
- * @jsx React.DOM
  */
-
+'use strict';
 var React = require('react');
 var cx = require('react/lib/cx');
 var openThread = require('../actions/openThread');

chat/components/ThreadSection.jsx

@@ -12,10 +12,8 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
- *
- * @jsx React.DOM
  */
-
+'use strict';
 var React = require('react');
 var MessageStore = require('../stores/MessageStore');
 var ThreadListItem = require('../components/ThreadListItem.jsx');

chat/services/message.js

@@ -65,7 +65,7 @@ var _messages = [
 
 module.exports = {
     name: 'message',
-    //At least one of the CRUD methods is required
+    // at least one of the CRUD methods is required
     read: function(req, resource, params, config, callback) {
         setTimeout(function () {
             callback(null, JSON.parse(JSON.stringify(_messages)));
@@ -84,7 +84,7 @@ module.exports = {
             callback(null, _messages);
         }, 10);
     }
-    //update: function(resource, params, body, config, callback) {},
-    //delete: function(resource, params, config, callback) {}
+    // update: function(resource, params, body, config, callback) {},
+    // delete: function(resource, params, config, callback) {}
 
 };

chat/stores/MessageStore.js

@@ -3,11 +3,10 @@
  * Copyrights licensed under the New BSD License. See the accompanying LICENSE file for terms.
  */
 'use strict';
-
-var util = require('util'),
-    BaseStore = require('fluxible-app/utils/BaseStore'),
-    debug = require('debug')('Example:MessageStore'),
-    ThreadStore = require('./ThreadStore');
+var util = require('util');
+var BaseStore = require('fluxible-app/utils/BaseStore');
+var debug = require('debug')('Example:MessageStore');
+var ThreadStore = require('./ThreadStore');
 
 function MessageStore(dispatcher) {
     this.dispatcher = dispatcher;
@@ -61,8 +60,8 @@ MessageStore.prototype.get = function (id) {
 };
 
 MessageStore.prototype.getAllForThread = function(threadID) {
-    var self = this,
-        threadMessages = [];
+    var self = this;
+    var threadMessages = [];
     self.sortedByDate.forEach(function (key) {
         var message = self.messages[key];
         if (message.threadID === threadID) {

chat/stores/ThreadStore.js

@@ -3,10 +3,9 @@
  * Copyrights licensed under the New BSD License. See the accompanying LICENSE file for terms.
  */
 'use strict';
-
-var util = require('util'),
-    BaseStore = require('fluxible-app/utils/BaseStore'),
-    debug = require('debug')('Example:ThreadStore');
+var util = require('util');
+var BaseStore = require('fluxible-app/utils/BaseStore');
+var debug = require('debug')('Example:ThreadStore');
 
 function ThreadStore(dispatcher) {
     this.dispatcher = dispatcher;
@@ -40,8 +39,8 @@ ThreadStore.prototype.getAll = function() {
 };
 
 ThreadStore.prototype.getAllChrono = function() {
-    var self = this,
-        orderedThreads = [];
+    var self = this;
+    var orderedThreads = [];
 
     Object.keys(this.threads).forEach(function (key) {
         var thread = self.threads[key];

chat/stores/UnreadThreadStore.js

@@ -3,11 +3,10 @@
  * Copyrights licensed under the New BSD License. See the accompanying LICENSE file for terms.
  */
 'use strict';
-
-var util = require('util'),
-    BaseStore = require('fluxible-app/utils/BaseStore'),
-    debug = require('debug')('Example:UnreadThreadStore'),
-    ThreadStore = require('./ThreadStore');
+var util = require('util');
+var BaseStore = require('fluxible-app/utils/BaseStore');
+var debug = require('debug')('Example:UnreadThreadStore');
+var ThreadStore = require('./ThreadStore');
 
 function UnreadThreadStore(dispatcher) {
     this.dispatcher = dispatcher;
@@ -23,22 +22,20 @@ UnreadThreadStore.handlers = {
 util.inherits(UnreadThreadStore, BaseStore);
 
 UnreadThreadStore.prototype.receiveMessages = function (messages) {
-    var self = this;
-    self.emitChange();
+    this.emitChange();
 };
 
 UnreadThreadStore.prototype.openThread = function (payload) {
-    var self = this;
-    self.emitChange();
+    this.emitChange();
 };
 
 UnreadThreadStore.prototype.getCount = function () {
     var threads = this.dispatcher.getStore(ThreadStore).getAll();
     var unreadCount = 0;
     for (var id in threads) {
-      if (!threads[id].lastMessage.isRead) {
-        unreadCount++;
-      }
+        if (!threads[id].lastMessage.isRead) {
+            unreadCount++;
+        }
     }
     return unreadCount;
 };

chat/webpack.config.js

@@ -9,18 +9,18 @@ module.exports = {
     resolve: {
         extensions: ['', '.js', '.jsx']
     },
-    entry: "./client.js",
+    entry: './client.js',
     output: {
         path: __dirname+'/build/js',
-        filename: "client.js"
+        filename: 'client.js'
     },
     module: {
         loaders: [
-            { test: /\.css$/, loader: "style!css" },
+            { test: /\.css$/, loader: 'style!css' },
             { test: /\.jsx$/, loader: 'jsx-loader' }
         ]
     },
     plugins: [
-        //new webpack.optimize.UglifyJsPlugin()
+        // new webpack.optimize.UglifyJsPlugin()
     ]
 };

routing/components/About.jsx

@@ -1,9 +1,8 @@
-/** @jsx React.DOM */
 /**
  * Copyright 2014, Yahoo! Inc.
  * Copyrights licensed under the New BSD License. See the accompanying LICENSE file for terms.
  */
-
+'use strict';
 var React = require('react');
 
 var About = React.createClass({

routing/components/Application.jsx

@@ -1,9 +1,8 @@
-/** @jsx React.DOM */
 /**
  * Copyright 2014, Yahoo! Inc.
  * Copyrights licensed under the New BSD License. See the accompanying LICENSE file for terms.
  */
-
+'use strict';
 var React = require('react');
 var Nav = require('./Nav.jsx');
 var Home = require('./Home.jsx');

routing/components/Head.jsx

@@ -1,5 +1,8 @@
+/**
+ * Copyright 2014, Yahoo! Inc.
+ * Copyrights licensed under the New BSD License. See the accompanying LICENSE file for terms.
+ */
 'use strict';
-
 var React = require('react');
 
 /**

routing/components/Home.jsx

@@ -1,9 +1,8 @@
-/** @jsx React.DOM */
 /**
  * Copyright 2014, Yahoo! Inc.
  * Copyrights licensed under the New BSD License. See the accompanying LICENSE file for terms.
  */
-
+'use strict';
 var React = require('react');
 
 var Home = React.createClass({

routing/components/Nav.jsx

@@ -1,11 +1,10 @@
-/** @jsx React.DOM */
 /**
  * Copyright 2014, Yahoo! Inc.
  * Copyrights licensed under the New BSD License. See the accompanying LICENSE file for terms.
  */
-
-var React = require('react'),
-    NavLink = require('flux-router-component').NavLink;
+'use strict';
+var React = require('react');
+var NavLink = require('flux-router-component').NavLink;
 
 var Nav = React.createClass({
     getInitialState: function () {

routing/components/Timestamp.jsx

@@ -1,9 +1,8 @@
-/** @jsx React.DOM */
 /**
  * Copyright 2014, Yahoo! Inc.
  * Copyrights licensed under the New BSD License. See the accompanying LICENSE file for terms.
  */
-
+'use strict';
 var React = require('react');
 var updateTime = require('../actions/updateTime');
 var TimeStore = require('../stores/TimeStore');

routing/server.js

@@ -2,6 +2,7 @@
  * Copyright 2014, Yahoo! Inc.
  * Copyrights licensed under the New BSD License. See the accompanying LICENSE file for terms.
  */
+'use strict';
 require('node-jsx').install({ extension: '.jsx' });
 var http = require('http');
 var express = require('express');