Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

go dep #165

Closed
mcuadros opened this issue Apr 23, 2018 · 1 comment
Closed

go dep #165

mcuadros opened this issue Apr 23, 2018 · 1 comment
Assignees
Labels
has pr Already has a PR

Comments

@mcuadros
Copy link
Contributor

This package is a library, and as a library shouldn't be using go dep, if vendor is required for certain packages, then only this packages should be vendored, and not the other dependencies.

And I bless God to not having anything vendored, in the near future.

@erizocosmico
Copy link
Contributor

dep is meant to be used with any kind of project, library or not, by design. Of course, without uploading the vendor dir.

The reason we have dep in this library is because if we do not it's a complete mess to setup jaeger. https://github.com/jaegertracing/jaeger-client-go#installation as they state in their README go geting the library may cause compilation errors and setting up the specific versions to make jaeger work is not trivial and we should not leave that step to the users of the library.

The only downside of using dep in the library is that it forces you to use dep on your application (or fight yourself the dependency mess jaeger creates), so I don't think it's that big of a deal.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has pr Already has a PR
Projects
None yet
Development

No branches or pull requests

2 participants