You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 28, 2021. It is now read-only.
This package is a library, and as a library shouldn't be using go dep, if vendor is required for certain packages, then only this packages should be vendored, and not the other dependencies.
And I bless God to not having anything vendored, in the near future.
The text was updated successfully, but these errors were encountered:
The reason we have dep in this library is because if we do not it's a complete mess to setup jaeger. https://github.com/jaegertracing/jaeger-client-go#installation as they state in their README go geting the library may cause compilation errors and setting up the specific versions to make jaeger work is not trivial and we should not leave that step to the users of the library.
The only downside of using dep in the library is that it forces you to use dep on your application (or fight yourself the dependency mess jaeger creates), so I don't think it's that big of a deal.
This package is a library, and as a library shouldn't be using
go dep
, if vendor is required for certain packages, then only this packages should be vendored, and not the other dependencies.And I bless God to not having anything vendored, in the near future.
The text was updated successfully, but these errors were encountered: