buildFromSdist: enable only for local packages (#298)

Author: srid

CHANGELOG.md

@@ -4,7 +4,7 @@
 
 - Breaking changes
   - #221: Switch from `buildFromCabalSdist` to `buildFromSdist`, to allow using non-standard package sets (wherein `cabal-install` is otherwise built without using user's overrides)
-    - #253: Enable controlling `buildFromSdist` through `settings.<name>.buildFromSdist`. (This was turned off by default originally, but was turned on by default in #286)
+    - #253: Enable controlling `buildFromSdist` through `settings.<name>.buildFromSdist`. (This was turned off by default originally, but was turned on by default in #286, limited to local packages in #298)
 - Enhancements
   - `settings` module:
     - #210: Add `extraLibraries` to `settings` module.

nix/modules/project/defaults.nix

@@ -84,21 +84,18 @@ in
       '';
       default =
         let
-          globalSettings = {
-            # Make sure all files we use are included in the sdist, as a check
-            # for release-worthiness.
-            buildFromSdist = lib.mkDefault true;
-          };
           localSettings = { name, package, config, ... }:
             lib.optionalAttrs (package.local.toDefinedProject or false) {
               # Disabling haddock and profiling is mainly to speed up Nix builds.
               haddock = lib.mkDefault false; # Because, this is end-user software. No need for library docs.
               libraryProfiling = lib.mkDefault false; # Avoid double-compilation.
+              # Make sure all files we use are included in the sdist, as a check
+              # for release-worthiness.
+              buildFromSdist = lib.mkDefault true;
             };
         in
         if config.defaults.enable then {
           imports = [
-            globalSettings
             localSettings
           ];
         } else { };