Idea: inform when publishing the same twice

[webpro]

Since the example/template has on: [push, pull_request] the job also runs on tags, resulting in two seemingly identical publishes for the same commit sha:

• https://github.com/webpro-nl/knip/actions/runs/9845618105/job/27181520125#step:6:14
• https://github.com/webpro-nl/knip/actions/runs/9845618200/job/27181519355#step:6:14

Nothing wrong here, but maybe nice to info/warn something like "this version was already published".

In the same vein, the Action template could be updated to something like this:

on:
  pull_request:
  push:
    branches:
      - '**'
    tags:
      - '!**'

Tags are usually published to npm anyway. Each push would still be published, though.

[Aslemammad]

That's for sure! Thank you so much for the suggestion, would you like to send a PR?

[webpro]

As much as I'd love to help out, I have more projects on my plate atm.

[Aslemammad]

For sure mate, will sort it out for you!

[Aslemammad]

Just sorted this out, will have a release soon!

[webpro]

Thank you! Couldn't wish for more 😊

[David-Pena]

Hi @Aslemammad @webpro I have a question about the implementation of this ⬆️

if I have this

on:
  push:
    branches: 
      - main
  pull_request:
    types: [closed]
    branches: 
      - main

Whats suggested in this issue is that I update the template to this ⬇️ ?

on:
  push:
    branches: 
      - '**'
    tags
      - '!**'
  pull_request:
    types: [closed]
    branches: 
      - '**'
    tags
      - '!**'

I know it might be a silly question but its for an OSS repo so I wouldnt want to suggest something wrong 👀

[webpro]

From https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#push:

Runs your workflow when you push a commit or tag

With the suggested config the workflow should not be triggered for any tag. I think we have to explicitly disable the tag part.

But I wouldn't worry too much about it, a mistake would be rather cheap here as this service itself is about publishing preview releases :)

[David-Pena]

Got it @webpro thanks for your reply 🙌