Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: react-query hey-api integration #101

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

alex-mcgovern
Copy link
Collaborator

@alex-mcgovern alex-mcgovern commented Jan 17, 2025

Integrates react-query with hey-api to being standardising query key & query option managment, which should help mitigate bugs like the one addressed in #99.

One important call out is because the react-query hey-api integration interacts directly with the client, I have remove the serverApi function, instead initialising the client once in the top level main.tsx module.

@coveralls
Copy link
Collaborator

coveralls commented Jan 17, 2025

Pull Request Test Coverage Report for Build 12827352251

Details

  • 20 of 33 (60.61%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 67.699%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main.tsx 0 1 0.0%
src/api/generated/@tanstack/react-query.gen.ts 19 31 61.29%
Totals Coverage Status
Change from base Build 12827058505: -0.7%
Covered Lines: 401
Relevant Lines: 515

💛 - Coveralls

@alex-mcgovern alex-mcgovern merged commit 58d4d47 into main Jan 17, 2025
7 of 8 checks passed
@alex-mcgovern alex-mcgovern deleted the feat/react-query-hey-api-integration branch January 17, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants