Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement breadcrumbs according to design #131

Merged
merged 12 commits into from
Jan 20, 2025
Merged

Conversation

kantord
Copy link
Member

@kantord kantord commented Jan 20, 2025

fixes #122

What's included:

  • Implement breadcrumbs on all pages, according to the design
  • Remove the need to leverage global state for breadcrumbs
  • use ui-kit breadcrumbs
Record_select-area_20250120154700.mp4

@kantord kantord force-pushed the breadcrumbs-refactor branch from dfedc62 to 15f26b9 Compare January 20, 2025 14:45
@coveralls
Copy link
Collaborator

coveralls commented Jan 20, 2025

Pull Request Test Coverage Report for Build 12870483113

Details

  • 4 of 6 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 67.118%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/route-certificates.tsx 3 5 60.0%
Totals Coverage Status
Change from base Build 12869295651: 0.4%
Covered Lines: 495
Relevant Lines: 656

💛 - Coveralls

@kantord kantord changed the title Breadcrumbs refactor feat: implement breadcrumbs according to design Jan 20, 2025
@kantord kantord marked this pull request as ready for review January 20, 2025 14:49
@kantord kantord enabled auto-merge (squash) January 20, 2025 14:51
<>
<Breadcrumbs>
<BreadcrumbHome />
<Breadcrumb>Help</Breadcrumb>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo this should extract the title from the document somehow, maybe using front matter yaml. but that's a bit too complex to include in this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or else we can switch to mdx, which would allow us to put the breadcrumbs react component into the markdown file itself, avoiding the need for any custom logic. That would work well unless we want to build a full fledged documentation feature with dozens of files

@kantord kantord merged commit 43fdf83 into main Jan 20, 2025
10 of 12 checks passed
@kantord kantord deleted the breadcrumbs-refactor branch January 20, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix breadcrumb related state handling
3 participants