Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: macos cert instructions #150

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

alex-mcgovern
Copy link
Collaborator

Fixes failing test in #148

@alex-mcgovern alex-mcgovern changed the title fix: MacOS cert instructions fix: macos cert instructions Jan 21, 2025
@alex-mcgovern alex-mcgovern enabled auto-merge (squash) January 21, 2025 13:38
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12888161169

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.96%

Totals Coverage Status
Change from base Build 12886542330: 0.0%
Covered Lines: 538
Relevant Lines: 693

💛 - Coveralls

@alex-mcgovern alex-mcgovern merged commit 81a1846 into main Jan 21, 2025
8 of 9 checks passed
@alex-mcgovern alex-mcgovern deleted the fix/certificates-instructions branch January 21, 2025 13:58
@danbarr
Copy link
Collaborator

danbarr commented Jan 21, 2025

FYI, this behavior is inconsistent between macOS versions - the steps originally documented were validated on Sequoia and still match what I just saw after deleting/re-adding my cert.

I suspect @ethomson may still be running Sonoma?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants