Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show banner in archived workspace #165

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

alex-mcgovern
Copy link
Collaborator

Closes #164

Screen.Recording.2025-01-22.at.10.47.45.AM.mov

@coveralls
Copy link
Collaborator

coveralls commented Jan 22, 2025

Pull Request Test Coverage Report for Build 12906676440

Details

  • 10 of 12 (83.33%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 69.143%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/workspace/hooks/use-restore-workspace-button.tsx 2 3 66.67%
src/routes/route-workspace.tsx 2 3 66.67%
Totals Coverage Status
Change from base Build 12905970062: 0.1%
Covered Lines: 609
Relevant Lines: 789

💛 - Coveralls

return useQuery({
...v1ListArchivedWorkspacesOptions(),
refetchInterval: 5_000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 why was this changed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not manually, might have been a formatter/linter

Copy link
Member

@kantord kantord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@alex-mcgovern alex-mcgovern merged commit e77a837 into main Jan 22, 2025
8 checks passed
@alex-mcgovern alex-mcgovern deleted the fix/show-banner-in-archived-workspace branch January 22, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: you can navigate to an archived workspace, but there is no visual feedback that it is archived
3 participants