Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement hard delete for workspaces & refactor workspaces table to allow multiple actions #185

Merged
merged 20 commits into from
Jan 24, 2025

Conversation

alex-mcgovern
Copy link
Collaborator

This PR does the following:

  • visually refactors the workspaces table:
    • whole row is now a link to the settings for that workspace
    • actions menu allows doing things quickly (archiving, restoring, deleting, activating)
  • adds the ConfirmProvider & useConfirm hooks from Minder
  • combines the data fetching & normalization for workspaces table into a single hook
  • implements optimistic updates for archiving/restoring
Screen.Recording.2025-01-23.at.5.01.20.PM.mov

@alex-mcgovern alex-mcgovern changed the title Feat/implement hard delete feat: implement hard delete for workspaces Jan 23, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 24, 2025

Pull Request Test Coverage Report for Build 12949002354

Details

  • 94 of 115 (81.74%) changed or added relevant lines in 18 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.8%) to 71.054%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/context/confirm-context.tsx 12 13 92.31%
src/features/workspace/components/workspace-custom-instructions.tsx 4 5 80.0%
src/features/workspace/hooks/use-mutation-set-workspace-custom-instructions.tsx 2 3 66.67%
src/hooks/use-confirm.tsx 4 5 80.0%
src/mocks/msw/handlers.ts 5 6 83.33%
src/features/workspace/hooks/use-mutation-archive-workspace.ts 10 18 55.56%
src/features/workspace/hooks/use-mutation-restore-workspace.ts 7 15 46.67%
Files with Coverage Reduction New Missed Lines %
src/api/generated/sdk.gen.ts 1 86.15%
src/api/generated/@tanstack/react-query.gen.ts 1 70.31%
Totals Coverage Status
Change from base Build 12948870017: 1.8%
Covered Lines: 724
Relevant Lines: 913

💛 - Coveralls

@alex-mcgovern alex-mcgovern changed the title feat: implement hard delete for workspaces feat: implement hard delete for workspaces & refactor workspaces table to allow multiple actions Jan 24, 2025
@alex-mcgovern alex-mcgovern merged commit a98492a into main Jan 24, 2025
9 checks passed
@alex-mcgovern alex-mcgovern deleted the feat/implement-hard-delete branch January 24, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants