fix: workspace hard delete nits #202
Merged
+135
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12953637666Details
💛 - Coveralls |
peppescg
reviewed
Jan 24, 2025
| return "Cannot archive the active workspace"; | ||
| } | ||
| if (workspaceName === "default") { | ||
| return "Cannot archive the default workspace"; |
There was a problem hiding this comment.
I guess we can use the BE error message here, cause it is semantically correct
There was a problem hiding this comment.
The BE error is Cannot delete default workspace which is actually a remnant, and I was about to open a PR to fix separate to this.
There was a problem hiding this comment.
Right 🤔 I don't know why I remember that it was correct
There was a problem hiding this comment.
Anyways we can update the BE message too, but I agree on this change for now
There was a problem hiding this comment.
peppescg
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #192