Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: quick "go to settings" for workspace selector #213

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

alex-mcgovern
Copy link
Collaborator

@alex-mcgovern alex-mcgovern commented Jan 28, 2025

Small UI tweak to add a link to each workspace's settings page in the workspace selector.

I also tidied up a few spacing/color inconsistencies in the workspace selector.

Screen.Recording.2025-01-28.at.11.20.38.AM.mov

@coveralls
Copy link
Collaborator

coveralls commented Jan 28, 2025

Pull Request Test Coverage Report for Build 13009890552

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 68.399%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/workspace/components/workspaces-selection.tsx 0 1 0.0%
Totals Coverage Status
Change from base Build 13009837492: 0.09%
Covered Lines: 771
Relevant Lines: 1027

💛 - Coveralls

Copy link
Collaborator

@peppescg peppescg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! it makes sense

@alex-mcgovern alex-mcgovern merged commit b683d56 into main Jan 28, 2025
7 checks passed
@alex-mcgovern alex-mcgovern deleted the feat/quick-go-to-settings-workspace-selector branch January 28, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants