Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workspace preferred model #217

Merged
merged 29 commits into from
Jan 29, 2025
Merged

feat: add workspace preferred model #217

merged 29 commits into from
Jan 29, 2025

Conversation

peppescg
Copy link
Collaborator

@peppescg peppescg commented Jan 28, 2025

Select preferred model from model providers endpoint.

BE is not ready, we are going to hide this section for now, so it is safe to merge it.

Kapture.2025-01-29.at.13.24.40.mp4

@peppescg peppescg self-assigned this Jan 28, 2025
Copy link

stacklok-cloud-staging bot commented Jan 28, 2025

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of 81dbe59d:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @dnd-kit/accessibility

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 6.9
User activity 7.9
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 12
Number of git tags or releases 121
Versions matched to tags or releases 8

📦 Dependency: @dnd-kit/core

Trusty Score: 0

Scoring details
Component Score
Package activity 7.6
Repository activity 6.9
User activity 8.3
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 134
Number of git tags or releases 128
Versions matched to tags or releases 41

📦 Dependency: @dnd-kit/sortable

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 6.9
User activity 7.9
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 106
Number of git tags or releases 125
Versions matched to tags or releases 21

📦 Dependency: @dnd-kit/utilities

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 6.9
User activity 7.9
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 87
Number of git tags or releases 88
Versions matched to tags or releases 12

📦 Dependency: uuid

Trusty Score: 0

Scoring details
Component Score
Package activity 7.7
Repository activity 6
User activity 9.4
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 45
Number of git tags or releases 48
Versions matched to tags or releases 29
Alternatives
Package Score Description
uuid-1345 0
uuid-random 0

@coveralls
Copy link
Collaborator

coveralls commented Jan 28, 2025

Pull Request Test Coverage Report for Build 13033214444

Details

  • 32 of 46 (69.57%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 72.297%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/mocks/msw/handlers.ts 0 2 0.0%
src/api/generated/sdk.gen.ts 3 6 50.0%
src/api/generated/@tanstack/react-query.gen.ts 7 16 43.75%
Totals Coverage Status
Change from base Build 13033106631: 0.8%
Covered Lines: 775
Relevant Lines: 1009

💛 - Coveralls

Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @dnd-kit/accessibility

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 7
User activity 8
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 12
Number of git tags or releases 121
Versions matched to tags or releases 8
Alternatives
Package Score Description
@reach/visually-hidden 0
@react-aria/visually-hidden 0

📦 Dependency: @dnd-kit/core

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 7
User activity 8
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 134
Number of git tags or releases 128
Versions matched to tags or releases 41
Alternatives
Package Score Description
react-dnd 0

📦 Dependency: @dnd-kit/sortable

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 7
User activity 8
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 106
Number of git tags or releases 125
Versions matched to tags or releases 21

📦 Dependency: @dnd-kit/utilities

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 7
User activity 8
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 87
Number of git tags or releases 88
Versions matched to tags or releases 12

📦 Dependency: uuid

Trusty Score: 0

Scoring details
Component Score
Package activity 7.7
Repository activity 6
User activity 9.4
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 45
Number of git tags or releases 48
Versions matched to tags or releases 29
Alternatives
Package Score Description
uuid-1345 0
uuid-random 0

Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @dnd-kit/accessibility

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 7
User activity 8
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 12
Number of git tags or releases 121
Versions matched to tags or releases 8
Alternatives
Package Score Description
@reach/visually-hidden 0
@react-aria/visually-hidden 0

📦 Dependency: @dnd-kit/core

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 7
User activity 8
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 134
Number of git tags or releases 128
Versions matched to tags or releases 41
Alternatives
Package Score Description
react-dnd 0

📦 Dependency: @dnd-kit/sortable

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 7
User activity 8
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 106
Number of git tags or releases 125
Versions matched to tags or releases 21

📦 Dependency: @dnd-kit/utilities

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 7
User activity 8
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 87
Number of git tags or releases 88
Versions matched to tags or releases 12
Alternatives
Package Score Description
@dnd-kit/core 0
@dnd-kit/sortable 0

📦 Dependency: uuid

Trusty Score: 0

Scoring details
Component Score
Package activity 7.7
Repository activity 6
User activity 9.4
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 45
Number of git tags or releases 48
Versions matched to tags or releases 29
Alternatives
Package Score Description
uuid-1345 0
uuid-random 0

Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @dnd-kit/accessibility

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 7
User activity 8
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 12
Number of git tags or releases 121
Versions matched to tags or releases 8
Alternatives
Package Score Description
@reach/visually-hidden 0
@react-aria/visually-hidden 0

📦 Dependency: @dnd-kit/core

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 7
User activity 8
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 134
Number of git tags or releases 128
Versions matched to tags or releases 41
Alternatives
Package Score Description
react-dnd 0

📦 Dependency: @dnd-kit/sortable

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 7
User activity 8
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 106
Number of git tags or releases 125
Versions matched to tags or releases 21

📦 Dependency: @dnd-kit/utilities

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 7
User activity 8
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 87
Number of git tags or releases 88
Versions matched to tags or releases 12
Alternatives
Package Score Description
@dnd-kit/core 0
@dnd-kit/sortable 0

📦 Dependency: uuid

Trusty Score: 0

Scoring details
Component Score
Package activity 7.7
Repository activity 6
User activity 9.4
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 45
Number of git tags or releases 48
Versions matched to tags or releases 29
Alternatives
Package Score Description
uuid-1345 0
uuid-random 0

Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @dnd-kit/accessibility

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 7
User activity 8
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 12
Number of git tags or releases 121
Versions matched to tags or releases 8
Alternatives
Package Score Description
@reach/visually-hidden 0
@react-aria/visually-hidden 0

📦 Dependency: @dnd-kit/core

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 7
User activity 8
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 134
Number of git tags or releases 128
Versions matched to tags or releases 41
Alternatives
Package Score Description
react-dnd 0

📦 Dependency: @dnd-kit/sortable

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 7
User activity 8
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 106
Number of git tags or releases 125
Versions matched to tags or releases 21

📦 Dependency: @dnd-kit/utilities

Trusty Score: 0

Scoring details
Component Score
Package activity 7.4
Repository activity 7
User activity 8
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 87
Number of git tags or releases 88
Versions matched to tags or releases 12
Alternatives
Package Score Description
@dnd-kit/core 0
@dnd-kit/sortable 0

📦 Dependency: uuid

Trusty Score: 0

Scoring details
Component Score
Package activity 7.7
Repository activity 6
User activity 9.4
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 45
Number of git tags or releases 48
Versions matched to tags or releases 29
Alternatives
Package Score Description
uuid-1345 0
uuid-random 0

@peppescg peppescg changed the title feat(muxing): add workspace model overrides feat(muxing): add workspace preferred model Jan 29, 2025
@peppescg peppescg changed the title feat(muxing): add workspace preferred model feat: add workspace preferred model Jan 29, 2025
@peppescg peppescg force-pushed the issues/209 branch 2 times, most recently from 5fc877e to 9e4adf9 Compare January 29, 2025 13:56
@peppescg peppescg linked an issue Jan 29, 2025 that may be closed by this pull request
@peppescg peppescg force-pushed the issues/209 branch 2 times, most recently from 0143e9c to 341bf2c Compare January 29, 2025 14:01
await invalidate();
},
successMsg: (variables) =>
`Preferred model on ${variables.path.workspace_name} successfully submitted!`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super tiny nit, just to make the message more consistent with existing ones

Suggested change
`Preferred model on ${variables.path.workspace_name} successfully submitted!`,
`Preferred model for "${variables.path.workspace_name}" updated`,

@@ -52,6 +53,11 @@ export function RouteWorkspace() {
className="mb-4"
workspaceName={name}
/>
<WorkspacePreferredModel
className="mb-4 hidden"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tailwind can truly do anything, even feature flags :trollface: 🚀

kantord
kantord previously approved these changes Jan 29, 2025
await waitFor(() => {
expect(
screen.getByText(
/preferred model on fake-workspace successfully submitted!/i,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The corresponding tweak for my other comment

Suggested change
/preferred model on fake-workspace successfully submitted!/i,
/preferred model for "fake-workspace" updated/i

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep makes sense, 🙏

alex-mcgovern
alex-mcgovern previously approved these changes Jan 29, 2025
@peppescg peppescg dismissed stale reviews from kantord and alex-mcgovern via 88588e7 January 29, 2025 14:13
@peppescg peppescg merged commit 90dfbe9 into main Jan 29, 2025
7 checks passed
@peppescg peppescg deleted the issues/209 branch January 29, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Muxing support within workspace
4 participants