Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial work on alerts summary cards #222

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

alex-mcgovern
Copy link
Collaborator

@alex-mcgovern alex-mcgovern commented Jan 29, 2025

  • adds the "alerts summary cards" to the UI
  • this is a "first-pass" PR, there is a second piece of work to make these work as triggers for filtering the table view — although I need to speak to James about this
  • this also begins refactoring the data fetching for alerts, which is a little complex — the goal is (over time) to break it down into smaller abstractions. To start with I have just updated the query key on the old useAlertsData hook, and marked it as deprecated, so there aren't any conflicts
  • closes Replace charts with other metrics box #196
  • closes [UI]: Integrate token usage #214
Screenshot 2025-01-29 at 1 18 12 PM

@coveralls
Copy link
Collaborator

coveralls commented Jan 29, 2025

Pull Request Test Coverage Report for Build 13032675856

Details

  • 20 of 20 (100.0%) changed or added relevant lines in 10 files are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+4.4%) to 71.513%

Files with Coverage Reduction New Missed Lines %
src/hooks/useAlertsData.ts 5 86.0%
src/lib/utils.ts 9 65.69%
Totals Coverage Status
Change from base Build 13032637167: 4.4%
Covered Lines: 743
Relevant Lines: 980

💛 - Coveralls

Copy link

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of fc09eabb:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

Copy link

@stacklok-cloud-staging stacklok-cloud-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @rollup/rollup-darwin-arm64

Trusty Score: 0

Scoring details
Component Score
Package activity 9
Repository activity 8.5
User activity 9.6
Provenance historical_provenance_match
Proof of Origin (Provenance)

This package can be linked back to its source code using a historical provenance map.

We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.

Published package versions 112
Number of git tags or releases 203
Versions matched to tags or releases 89

@alex-mcgovern alex-mcgovern merged commit 2732434 into main Jan 29, 2025
9 checks passed
@alex-mcgovern alex-mcgovern deleted the features/alerts-summary-cards branch January 29, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI]: Integrate token usage Replace charts with other metrics box
3 participants