feat: show alert detail in the conversation page #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13201838771Details
💛 - Coveralls |
peppescg
changed the title
davolokh
previously approved these changes
Feb 7, 2025
|
@peppescg can we also (in a separated pr) add a |
davolokh
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I retrieved the old logic for showing secrets and malicious pkg alerts, showing it into the conversation page.
We have a lot of dogecoin secret false positive, that we need to solve on BE ( issue created here)
We are going to fine tune this section, but I guess for now it would be better to show this kind of detail rather than hide them.