Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend new revert logic to "custom instructions" #304

Merged
merged 9 commits into from
Feb 12, 2025

Conversation

kantord
Copy link
Member

@kantord kantord commented Feb 11, 2025

2025-02-11.18-30-23.mp4

This PR:

  • removes jsonforms as promised
  • extends the same new logic to custom instructions
  • contains some small refactors
  • seems like (accidentally) fixes Toggling active workspace while editing is detected as making changes to the form #291
  • does not yet include the new logic for preferred model. I am still working on that, will open a new PR for it. It just has slightly more tricky logic due to how the state management works there, so it's better to get a seperate feedback for this "general case" before

@kantord kantord marked this pull request as ready for review February 11, 2025 17:36
@kantord kantord requested review from alex-mcgovern and peppescg and removed request for alex-mcgovern February 11, 2025 17:37
@kantord kantord changed the title Remove jsonforsm feat: extend new revert logic to "custom instructions" Feb 11, 2025
@kantord kantord merged commit 40f86a5 into main Feb 12, 2025
7 checks passed
@kantord kantord deleted the remove-jsonforsm branch February 12, 2025 09:43
@coveralls
Copy link
Collaborator

coveralls commented Feb 13, 2025

Pull Request Test Coverage Report for Build 13281988581

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 24 of 25 (96.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 68.137%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/workspace/components/workspace-custom-instructions.tsx 10 11 90.91%
Totals Coverage Status
Change from base Build 13281785995: 0.6%
Covered Lines: 755
Relevant Lines: 1048

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggling active workspace while editing is detected as making changes to the form
3 participants