Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error UI styling bug #307

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

alex-mcgovern
Copy link
Collaborator

@alex-mcgovern alex-mcgovern commented Feb 12, 2025

Fixes a bug where the error fallback UI was not capped to the same max width as the rest of the UI.

Also makes it more consistent by re-using a generic "EmptyState" component that is used elsewhere in the UI already.

Before

Screenshot 2025-02-12 at 8 33 09 AM

After

Screenshot 2025-02-12 at 8 32 53 AM

Closes #299

@alex-mcgovern alex-mcgovern enabled auto-merge (squash) February 12, 2025 08:37
@alex-mcgovern alex-mcgovern merged commit 00bf204 into main Feb 12, 2025
8 checks passed
@alex-mcgovern alex-mcgovern deleted the fix/error-state-styling-bug branch February 12, 2025 09:08
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13281241574

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on fix/error-state-styling-bug at 67.507%

Totals Coverage Status
Change from base Build 13281100678: 67.5%
Covered Lines: 786
Relevant Lines: 1092

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error fallback UI doesn't match width of rest of user interface
3 participants