Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: focus ring in version dropdown #314

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

alex-mcgovern
Copy link
Collaborator

Fixes this bug reported by @jtenniswood

Screenshot 2025-02-14 at 8 05 19 AM

kantord
kantord previously approved these changes Feb 14, 2025
Copy link
Member

@kantord kantord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but it has a conflict

@alex-mcgovern alex-mcgovern merged commit 3a00cfa into main Feb 14, 2025
7 checks passed
@alex-mcgovern alex-mcgovern deleted the fix/focus-ring-version-dropdown branch February 14, 2025 11:33
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13328332712

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 68.625%

Totals Coverage Status
Change from base Build 13325601630: 0.06%
Covered Lines: 769
Relevant Lines: 1061

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants