Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cert instructions #317

Merged
merged 12 commits into from
Feb 14, 2025
Merged

fix: cert instructions #317

merged 12 commits into from
Feb 14, 2025

Conversation

alex-mcgovern
Copy link
Collaborator

@alex-mcgovern alex-mcgovern commented Feb 14, 2025

Carries forward some work by @danbarr to update the certificate install steps.

Changes the implementation to use markdown to allow for richer formatting, also makes some opinionated changes to the documentation to make them a little easier on the eyes, now that we have rich formatting capabilities.

Screenshots

linux-remove-cert linux-install-cert windows-remove-cert windows-install-cert macos-remove-cert macos-install-cert

danbarr and others added 5 commits February 12, 2025 17:09
- Add some extra clarity about the uniqueness of the CA cert
- List the simpler CLI method first for macOS
- Clarify version differences for Keychain Access behavior
- Correct the Linux steps (VS Code uses nssdb, not the system certs)
- Add some extra clarity about the uniqueness of the CA cert
- List the simpler CLI method first for macOS
- Clarify version differences for Keychain Access behavior
- Correct the Linux steps (VS Code uses nssdb, not the system certs)
Copy link

stacklok-cloud-staging bot commented Feb 14, 2025

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of a649d172:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

kantord
kantord previously approved these changes Feb 14, 2025
@danbarr
Copy link
Collaborator

danbarr commented Feb 14, 2025

Love this, thanks @alex-mcgovern !!

@alex-mcgovern alex-mcgovern merged commit 2eb9579 into main Feb 14, 2025
7 checks passed
@alex-mcgovern alex-mcgovern deleted the fix-cert-instructions branch February 14, 2025 16:38
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13333113910

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.3%) to 69.47%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/route-certificates.tsx 3 5 60.0%
Totals Coverage Status
Change from base Build 13332617912: 1.3%
Covered Lines: 827
Relevant Lines: 1132

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants