Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot delete endpoint URL #318

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix: cannot delete endpoint URL #318

merged 1 commit into from
Feb 14, 2025

Conversation

kantord
Copy link
Member

@kantord kantord commented Feb 14, 2025

fixes: #284

@kantord kantord marked this pull request as ready for review February 14, 2025 12:53
@@ -11,6 +11,7 @@ export function RouteProviderUpdate() {
if (id === undefined) {
throw new Error('Provider id is required')
}
console.log('I was rendered')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover

@@ -12,6 +12,7 @@ export function useProvider(providerId: string) {
endpoint: '',
api_key: '',
})
console.log(provider)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover

@kantord kantord force-pushed the bug-cannot-delete-endpoint branch from 3d680c4 to 0c55124 Compare February 14, 2025 12:55
@coveralls
Copy link
Collaborator

coveralls commented Feb 14, 2025

Pull Request Test Coverage Report for Build 13329641500

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 68.146%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/route-provider-create.tsx 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/routes/route-provider-create.tsx 1 16.67%
Totals Coverage Status
Change from base Build 13328677054: 0.06%
Covered Lines: 823
Relevant Lines: 1136

💛 - Coveralls

@kantord kantord merged commit 18ac940 into main Feb 14, 2025
8 checks passed
@kantord kantord deleted the bug-cannot-delete-endpoint branch February 14, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot delete provider URL
3 participants