Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: strip markdown in messages table #336

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Conversation

kantord
Copy link
Member

@kantord kantord commented Feb 19, 2025

fixes #321

Before

Screenshot_select-area_20250219120032

After

Screenshot_select-area_20250219120021

Explanation

In order to fix visual issues there, I decided to simply strip markdown (=convert .md to .txt) in the table. While there could be alternative solutions, such as only stripping problematic things from the prompt and displaying the rest, I think

  • it would not help the users much
  • could even be a performance issue
  • lot of code to maintain
  • perhaps we won't even keep this column, or we will display an ai generate summary or similar

For the implementation I used remark and a remark plugin, because we already indirectly depend on remark, so this way the added dependencies should be minimized.

Copy link

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of c228e332:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

@kantord kantord marked this pull request as ready for review February 19, 2025 11:01
@coveralls
Copy link
Collaborator

coveralls commented Feb 19, 2025

Pull Request Test Coverage Report for Build 13410965963

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 69.945%

Totals Coverage Status
Change from base Build 13410704822: 0.03%
Covered Lines: 847
Relevant Lines: 1153

💛 - Coveralls

@kantord kantord merged commit 2f8ab95 into main Feb 19, 2025
9 checks passed
@kantord kantord deleted the strip-markdown-from-promtps branch February 19, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Conversations table — transform prompts to be more human-readable
3 participants